Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mainnet appconfig for wsteth/usdc and eeth pools #1394

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Add mainnet appconfig for wsteth/usdc and eeth pools #1394

merged 2 commits into from
Aug 22, 2024

Conversation

DannyDelott
Copy link
Contributor

Fix remaining issues with the wsteth/usdc decimals and include the latest pools from the registry in mainnet appconfig.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2024

⚠️ No Changeset found

Latest commit: dbba4db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Aug 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 8:40pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 8:40pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Aug 22, 2024 8:40pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Aug 22, 2024 8:40pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Aug 22, 2024 8:40pm
testnet-v1 ⬜️ Ignored (Inspect) Aug 22, 2024 8:40pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Aug 22, 2024 8:40pm
trading-competition ⬜️ Ignored (Inspect) Aug 22, 2024 8:40pm

ryangoree
ryangoree approved these changes Aug 22, 2024
View reviewed changes
apps/hyperdrive-trading/src/base/calculateRatio.ts
@@ -9,5 +9,5 @@ export function calculateRatio({
b: bigint;
decimals: number;
}): bigint {
return fixed(a, decimals).div(b, decimals).mul(100, 0).bigint;
return fixed(fixed(a, decimals).div(b, decimals).mul(100, 0)).bigint;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryangoree Need to find a better solution for altering decimals of existing instances.

apps/hyperdrive-trading/src/ui/hyperdrive/lp/hooks/usePreviewAddLiquidity.ts
@@ -100,7 +100,7 @@ export function usePreviewAddLiquidity({

return {
status: queryStatus,
previewAddLiquidityError: error as string,
previewAddLiquidityError: error as Error,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryangoree Fix error.name for SDK errors.

@DannyDelott DannyDelott merged commit 90a0125 into main Aug 22, 2024
14 checks passed
@DannyDelott DannyDelott deleted the danny-ryan-usdc-bugfixes branch August 22, 2024 20:41
@ryangoree ryangoree mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryangoree ryangoree ryangoree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DannyDelott @ryangoree