Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Open LP Positions by Yield Source and Chain Id #1670

Merged
merged 12 commits into from
Dec 5, 2024

Conversation

jackburrus
Copy link
Contributor

@jackburrus jackburrus commented Dec 5, 2024

This PR refactors the Open LP position tables on the portfolio to take an array of Hyperdrives grouped by yield source. Previously, each Hyperdrive instance rendered one table with one row if there was an open LP position. By grouping these positions by yield source we can add open position totals to the top of each table.
Screenshot 2024-12-04 at 5 13 56 PM

Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: 7603a7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 4:38pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 4:38pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 4:38pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 4:38pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 4:38pm
testnet-v1 ⬜️ Ignored (Inspect) Dec 5, 2024 4:38pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 4:38pm
trading-competition ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 4:38pm

Comment on lines 21 to 27
for (const hyperdrive of appConfig.hyperdrives) {
const key = `${hyperdrive.chainId}-${hyperdrive.yieldSource}`;
if (!hyperdrivesByChainAndYieldSource[key]) {
hyperdrivesByChainAndYieldSource[key] = [];
}
hyperdrivesByChainAndYieldSource[key].push(hyperdrive);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's use lodash's groupBy to do this.

export function useTotalOpenLpPositions({
account,
openLpPositions,
enabled,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this should default to true to be consistent with our other hooks that have an enabled arg

</div>
{/* Custom border with inset for the first and last header cells */}
<span
<>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Longs and Shorts tables, there's a gap-6 between the header and the table, and a gap-10 between the different sections. It's subtle, but it looks like the LP tab has equal spacing between everything. Can we match the whitespace here with the other tabs?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants