Add rewards field to top-level appconfig
#1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
DannyDelott
force-pushed
the
danny-rewards-appconfig
branch
from
5ffc4c1 to
efc8686
Compare
DannyDelott
force-pushed
the
danny-rewards-appconfig
branch
from
efc8686 to
5fc7955
Compare
jackburrus
reviewed
Jan 3, 2025
| @@ -624,6 +614,14 @@ export async function getAppConfig({ | |||
| tokens.push(sharesTokenConfig); | |||
| } | |||
|
|
|||
| if (rewards) { | |||
| console.log("rewards", rewards); | |||
ryangoree
approved these changes
Jan 3, 2025
| @@ -624,6 +614,14 @@ export async function getAppConfig({ | |||
| tokens.push(sharesTokenConfig); | |||
| } | |||
|
|
|||
| if (rewards) { | |||
| console.log("rewards", rewards); | |||
DannyDelott
force-pushed
the
danny-rewards-appconfig
branch
from
047f067 to
ec5f558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewards are now a core feature of appconfig, allowing for greater flexibility in assigning rewards. You can now attach rewards to virtually anything, whether it’s a specific hyperdrive position, an entire pool, or any other element—anything can have a reward.
The
rewardsfield in appconfig lets you specify a key that maps to a list of reward resolvers. For instance:• A reward for adding liquidity to a pool would use a key like
hyperdrive-lp/0xabc....• A reward for opening a short position in a pool would use a key like
hyperdrive-short/0xabc....This approach eliminates the need to store reward details in
HyperdriveConfigorYieldSourceConfig. To check if a pool has a reward, simply look up the corresponding key in the rewards object.