Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update artifacts to v1.0.20 #1702

Merged
merged 2 commits into from
Jan 2, 2025
Merged

update artifacts to v1.0.20 #1702

merged 2 commits into from
Jan 2, 2025

Conversation

jackburrus
Copy link
Contributor

@jackburrus jackburrus commented Jan 2, 2025 •
edited
Loading

This PR updates artifacts to the latest version v.1.0.20

@vercel Vercel
Copy link

vercel bot commented Jan 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:24pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:24pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 8:24pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 8:24pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 8:24pm
testnet-v1 ⬜️ Ignored (Inspect) Jan 2, 2025 8:24pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 8:24pm
trading-competition ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 8:24pm

jackburrus
jackburrus commented Jan 2, 2025
View reviewed changes
packages/hyperdrive-js/src/hyperdrive/abi.ts Outdated
export const hyperdriveAbi = IHyperdrive.abi;
export type HyperdriveAbi = typeof IHyperdrive.abi;

export const zapAbi = UniV3Zap.abi;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V1.0.20 includes the UniV3Zap contract

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add this to the exports/index.ts file. Also, since zaps are a layer on top of hyperdrive, i think this should live in src/zaps/abi.ts instead.

DannyDelott
DannyDelott approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@DannyDelott DannyDelott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/hyperdrive-js/src/hyperdrive/abi.ts Outdated
export const hyperdriveAbi = IHyperdrive.abi;
export type HyperdriveAbi = typeof IHyperdrive.abi;

export const zapAbi = UniV3Zap.abi;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add this to the exports/index.ts file. Also, since zaps are a layer on top of hyperdrive, i think this should live in src/zaps/abi.ts instead.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2025

🦋 Changeset detected

Latest commit: daaecb5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@delvtech/hyperdrive-artifacts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jackburrus jackburrus merged commit 6da6183 into main Jan 2, 2025
15 checks passed
@jackburrus jackburrus deleted the update-artifacts-v20 branch January 2, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DannyDelott DannyDelott DannyDelott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackburrus @DannyDelott