Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rust calculate_initial_bond_reserves to be more general #35

Closed
dpaiton opened this issue Apr 17, 2024 · 1 comment
Closed

update rust calculate_initial_bond_reserves to be more general #35

dpaiton opened this issue Apr 17, 2024 · 1 comment
Assignees
@dpaiton
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dpaiton
Copy link
Member

dpaiton commented Apr 17, 2024

The calculate_initial_bond_reserves function could really be calculate_bonds that takes shares, rate, and vault_share_price as arguments. This generalizes the utility beyond deploying pools to be able to answer more abstract questions about what bond reserves should be for a certain pool state.
@dpaiton dpaiton added the enhancement New feature or request label Apr 17, 2024
@dpaiton dpaiton mentioned this issue Apr 17, 2024
Merged
@dpaiton dpaiton added the good first issue Good for newcomers label Apr 17, 2024
@dpaiton dpaiton self-assigned this May 1, 2024
@ryangoree ryangoree transferred this issue from delvtech/hyperdrive May 1, 2024
This was referenced May 8, 2024
Closed
Open
@dpaiton
Copy link
Member Author

dpaiton commented May 15, 2024

Done in #94

@dpaiton dpaiton closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpaiton dpaiton

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dpaiton