Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix calc_max_* #62

Closed
wakamex opened this issue May 2, 2024 · 2 comments
Closed

fix calc_max_* #62

wakamex opened this issue May 2, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@wakamex
Copy link
Contributor

wakamex commented May 2, 2024 •
edited
Loading

case 1: crash on calc max short with a high fixed rate of 100%

failing test here: #19

I noticed our fuzz ranges seem too narrow. should we do all of them up to 100% fixed rate? also in some cases fixed rate is not fuzzed.
@wakamex wakamex added the bug Something isn't working label May 2, 2024
@wakamex wakamex changed the title crash on calc max short with a high fixed rate (100%) calc_max accuracy May 3, 2024
@wakamex
Copy link
Contributor Author

wakamex commented May 3, 2024

case 2: crash trying to open long over 70% of the calculated max long after adding liquidity delvtech/agent0@7434b96

@wakamex wakamex changed the title calc_max accuracy calc_max accuracy (2 cases) May 3, 2024
@wakamex wakamex changed the title calc_max accuracy (2 cases) calc_max failure (2 cases) May 3, 2024
@dpaiton dpaiton changed the title calc_max failure (2 cases) accuracy errors with calc_max_* May 3, 2024
@dpaiton dpaiton changed the title accuracy errors with calc_max_* fix calc_max_* May 3, 2024
@wakamex
Copy link
Contributor Author

wakamex commented May 3, 2024

closed in favor of #45

@wakamex wakamex closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wakamex