avoid negative fixed point value in calc_max_short #19
+91
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wakamex
commented
May 1, 2024
•
wakamex
commented
- avoid negative fixed point value in calc_max_short by removing unnecessary brackets
- widen factory settings to allow time stretch and fixed rates in the range of 0-1000% (from 1-50%)
wakamex
requested review from
jalextowle,
jrhea,
mcclurejt,
dpaiton,
sentilesdal and
ryangoree
as code owners
wakamex
added
bug
This was referenced May 2, 2024
Closed
wakamex
force-pushed
the
separate_subtractions
branch
from
4ef681e to
c874cc5
Compare
wakamex
changed the title
wakamex
force-pushed
the
separate_subtractions
branch
from
c246b8a to
06a9c6d
Compare
wakamex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.