Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tolerance for fuzz_calculate_spot_price_after_short #939

Closed
wants to merge 2 commits into from

Conversation

ryangoree
Copy link
Member

Description

The fuzz_calculate_spot_price_after_short test was intermittently failing with it's current tolerance of fixed!(1e10). This PR bumps it to fixed!(1e11).

[[Reviewer Name]]

Rust

  • Testing
    • Are there new or updated unit or integration tests?
    • Do the tests cover the happy paths?
    • Do the tests cover the unhappy paths?
    • Are there an adequate number of fuzz tests to ensure that we are
      covering the full input space?
    • If matching Solidity behavior, are there differential fuzz tests that
      ensure that Rust matches Solidity?

@mcclurejt
Copy link
Contributor

any idea as to why this started happening?

@dpaiton
Copy link
Contributor

dpaiton commented Apr 4, 2024

any idea as to why this started happening?

I think 1e11 (aka correct up to the 8th decimal) is pretty reasonable given that the spot price itself is an approximation of the realized price for a non-infinitesimal trade size.

That being said, AFAIK this was not failing before the latest flurry of activity in the rust part of the repo. I'm going to approve to unblock other PRs from landing with this failing, but I think we should keep it in mind in case we start seeing more failures.

@ryangoree
Copy link
Member Author

That being said, AFAIK this was not failing before the latest flurry of activity in the rust part of the repo.

Because the test added in the flurry #919

@dpaiton
Copy link
Contributor

dpaiton commented Apr 4, 2024

I absorbed this PR into #938 so that we could have both fixes in one PR and CI would pass. Closing this PR.

@dpaiton dpaiton closed this Apr 4, 2024
@dpaiton dpaiton deleted the ryangoree/rust/patch-tolerance branch April 4, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants