Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In web3.py function construction and execution are separated:
This leads to problems if we want to provide typed return values from call() when doSomething() is overloaded:
For example, if x and xy versions have the same return signature, then we don't want to declare multiple call() methods. If they do, then we want multple methods, but how do we know which one to call? We can't. We either have to provide multiple return signatures or have doSomething(x) and doSomething(x,y) return different call() methods.
A future improvement would be to change the invocation pattern to:
For now, if there are multiple return signatures we simply set the return signature to
Any
and avoid overloading call() all together. This is probably a very edge case and can be improved in the future.