Display single movie #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalebCyphers
approved these changes
Dec 4, 2020
Comment on lines
+1
to
+22
| import React from 'react' | ||
| import './SelectedMovie.css' | ||
| import mockMovie from '../../mockMovie.js' | ||
|
|
||
| function SelectedMovie(props) { | ||
| return ( | ||
| <section className="selectedMovie"> | ||
| <h1>{props.title}</h1> | ||
| <img src={props.poster} alt={props.title} /> | ||
| <h1>{mockMovie.movie.title}</h1> | ||
| <h2>{mockMovie.movie.tagline}</h2> | ||
| <img src={mockMovie.movie.backdrop_path} /> | ||
| <p>Overview: {mockMovie.movie.overview}</p> | ||
| <p>Release Date: {mockMovie.movie.release_date}</p> | ||
| <p>Rating: {mockMovie.movie.average_rating}</p> | ||
| <p>Genre: {mockMovie.movie.genres[0].name}</p> | ||
| <p>Budget: ${mockMovie.movie.budget}</p> | ||
| <p>Revenue: ${mockMovie.movie.revenue}</p> | ||
| <p>Duration: {mockMovie.movie.runtime} minutes</p> | ||
| </section> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Happy to have this all coded up - will need to refactor eventually
| <button | ||
| className="nav-bar" | ||
| onClick={props.returnToHome}> | ||
| imma DINGUS |
There was a problem hiding this comment.
Can't forget to fix this
Comment on lines
+16
to
+28
|
|
||
| returnToHome = event => { | ||
| this.setState({ | ||
| selectedMovie: 0 | ||
| }) | ||
| } | ||
|
|
||
| handleClick = event => { | ||
| this.setState({ | ||
| selectedMovie: event.target | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
perhaps eventually we can make these one function
There was a problem hiding this comment.
Also event.target should resolve to an id, insted of setting the state to the full target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Catalogue, it will render theApp, displaying only that selected movie's poster & title (& ourmockMoviedata).NavBarbutton, theAppwill re-render back to displaying only theCataloguecomponent.Where should the reviewer start?
App.js, MovieCard.js, SelectedMovie.js, NavBar.js
How should this be manually tested?
Any background context you want to provide?
Still need to add CSS stylings to the Components as well as Testing suites.
What are the relevant tickets?
Closes #10 #9 #8 .