Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async testing #13

Merged
merged 9 commits into from
Dec 5, 2020
Merged

Async testing #13

merged 9 commits into from
Dec 5, 2020

Conversation

CalebCyphers
Copy link
Collaborator

@CalebCyphers CalebCyphers commented Dec 5, 2020

What does this PR do?

  • Adds Bootstrap package
  • Adds userEvent
  • Adds sass compiler
  • Adds minimal styling
  • Adds carosel
  • Adds loader
  • removes mock data
  • adds apiCalls.js file
  • adds tests to app.js

Where should the reviewer start?

  • App.js

How should this be manually tested?

  • run npm start and poke around

Any background context you want to provide?

  • After pulling, reviewer will need to run npm install

Tickets

Closes #9, #11, #13

@CalebCyphers CalebCyphers added the testing U KNO WHAT TESTING IS U DINGUS label Dec 5, 2020
"react": "^17.0.1",
"react-bootstrap": "^1.4.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to getting more familiar with React Bootstrap!

<Row>
<Col className="d-flex justify-content-center">
<img
src="http://forgifs.com/gallery/d/301665-4/Girl-trips-spills-popcorn.gif"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see it

opacity: 1 !important;
}

.card:hover > .card-img{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCSS looks so good!

import { Carousel } from "react-bootstrap";
import "./FeaturedMovies.scss";

function FeaturedMovies() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to make some changes to this

@demaceo demaceo merged commit 264ef78 into main Dec 5, 2020
@CalebCyphers CalebCyphers mentioned this pull request Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing U KNO WHAT TESTING IS U DINGUS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Individual movie details
2 participants