Skip to content

Comments

Pre-release cleanup: config alignment, build scripts, docs fix, whitespace#96

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/run-agents-and-apply-improvements
Feb 20, 2026
Merged

Pre-release cleanup: config alignment, build scripts, docs fix, whitespace#96
Malcolmnixon merged 2 commits intomainfrom
copilot/run-agents-and-apply-improvements

Conversation

Copy link
Contributor

Copilot AI commented Feb 19, 2026

Pull Request

Description

Ran all 6 specialized agents (repo-consistency, requirements, code-quality, technical-writer, software-developer, test-developer) to surface improvements ahead of a new release.

Critical fix: Self-validation test documentation in docs/guide/guide.md listed 5 incorrect test names that don't match the actual 4 tests in Validation.cs.

  • Config alignment with TemplateDotNetTool:
    • Added end_of_line = lf to .editorconfig
    • Added "MD025": false to .markdownlint-cli2.jsonc
  • Build script improvements:
    • build.sh / build.bat — added user feedback, self-validation step, removed redundant dotnet restore (already implicit in dotnet build)
  • Code formatting:
    • dotnet format fixed trailing whitespace in 6 source/test files
  • Documentation accuracy:
    • Updated validation test table and example output in docs/guide/guide.md to match implementation

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint '**/*.{yml,yaml}'

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

172/172 tests pass on net8.0, net9.0, net10.0. Self-validation 4/4. CodeQL: 0 alerts.

Agent reports (not committed) are available as AGENT_REPORT_*.md locally for reference.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/BuildMark/BuildMark/test/DemaConsulting.BuildMark.Tests/bin/Release/net10.0/DemaConsulting.BuildMark.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/BuildMark/BuildMark/test/DemaConsulting.BuildMark.Tests/bin/Release/net10.0/DemaConsulting.BuildMark.Tests.deps.json /home/REDACTED/work/BuildMark/BuildMark/test/DemaConsulting.BuildMark.Tests/bin/Release/net10.0/testhost.dll --port 42397 --endpoint 127.0.0.1:042397 --role client --parentprocessid 4849 --telemetryoptedin false (http block)
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/BuildMark/BuildMark/test/DemaConsulting.BuildMark.Tests/bin/Release/net8.0/DemaConsulting.BuildMark.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/BuildMark/BuildMark/test/DemaConsulting.BuildMark.Tests/bin/Release/net8.0/DemaConsulting.BuildMark.Tests.deps.json /home/REDACTED/work/BuildMark/BuildMark/test/DemaConsulting.BuildMark.Tests/bin/Release/net8.0/testhost.dll --port 42195 --endpoint 127.0.0.1:042195 --role client --parentprocessid 4848 --telemetryoptedin false (http block)
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/BuildMark/BuildMark/test/DemaConsulting.BuildMark.Tests/bin/Release/net9.0/DemaConsulting.BuildMark.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/BuildMark/BuildMark/test/DemaConsulting.BuildMark.Tests/bin/Release/net9.0/DemaConsulting.BuildMark.Tests.deps.json /home/REDACTED/work/BuildMark/BuildMark/test/DemaConsulting.BuildMark.Tests/bin/Release/net9.0/testhost.dll --port 34365 --endpoint 127.0.0.1:034365 --role client --parentprocessid 4847 --telemetryoptedin false (http block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…ts, whitespace

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Run agents and apply identified improvements for release Pre-release cleanup: config alignment, build scripts, docs fix, whitespace Feb 20, 2026
Copilot AI requested a review from Malcolmnixon February 20, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants