Skip to content

Repository cleanup: Follow template patterns and remove incorrect additions#103

Merged
Malcolmnixon merged 8 commits intomainfrom
copilot/review-reqstream-repo-findings
Feb 11, 2026
Merged

Repository cleanup: Follow template patterns and remove incorrect additions#103
Malcolmnixon merged 8 commits intomainfrom
copilot/review-reqstream-repo-findings

Conversation

Copy link
Contributor

Copilot AI commented Feb 11, 2026

Pull Request

Description

Comprehensive cleanup to align repository with TemplateDotNetTool patterns. Removed incorrectly added CHANGELOG.md (changes are documented via build notes), simplified bloated build/lint scripts to match template, cleaned up configuration files to use proper AGENT_REPORT_*.md naming convention, fixed duplicate workflow steps, and resolved linting issues.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

N/A

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint '**/*.{yml,yaml}'

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

Changes Made:

  1. Removed CHANGELOG.md - Repository uses build notes system for change documentation
  2. Simplified build/lint scripts - Replaced bloated versions (210 lines removed) with clean TemplateDotNetTool template versions
  3. Cleaned configuration files - Removed bogus ignore patterns (-review-report.md, CODE_QUALITY_REPORT.md, DOCUMENTATION_REVIEW.md) that were created when agents didn't follow AGENT_REPORT_.md naming convention
  4. Fixed build.yaml - Removed duplicate "Download integration test results" step (already covered by test-results pattern)
  5. Removed duplicate patterns - Cleaned up duplicate node_modules/** entry in markdownlint config
  6. Fixed lint issue - Added "slnx" to spell check dictionary to recognize the new solution file format

All 117 tests pass. Build succeeds with 0 warnings, 0 errors. All linting passes (cspell, markdownlint, yamllint, dotnet format).


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 4 commits February 11, 2026 19:32
…formatting

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
…nt.bat)

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
… ARCHITECTURE.md

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix findings from ReqStream repo review Repository modernization: agents review findings and template compliance Feb 11, 2026
Copilot AI requested a review from Malcolmnixon February 11, 2026 19:43
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title Repository modernization: agents review findings and template compliance Remove CHANGELOG.md - use build notes for change documentation Feb 11, 2026
…licate download step

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title Remove CHANGELOG.md - use build notes for change documentation Repository cleanup: Follow template patterns and remove incorrect additions Feb 11, 2026
Copilot AI requested a review from Malcolmnixon February 11, 2026 19:56
@Malcolmnixon Malcolmnixon marked this pull request as ready for review February 11, 2026 19:59
@Malcolmnixon
Copy link
Contributor

@copilot Please fix the lint issues

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 11, 2026

@copilot Please fix the lint issues

Fixed in commit a3d38a3. Added "slnx" to the spell check dictionary. All linting now passes (cspell, markdownlint, yamllint, dotnet format).

Copilot AI requested a review from Malcolmnixon February 11, 2026 20:05
@Malcolmnixon Malcolmnixon merged commit f71c5ea into main Feb 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants