Skip to content

[WIP] Review software quality and address build warnings #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Malcolmnixon merged 2 commits into from
Jan 9, 2026
Merged

[WIP] Review software quality and address build warnings #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
065555a
Initial plan
Copilot Jan 9, 2026
3be08e7
Fix all MSTest analyzer warnings and configure test parallelization
Copilot Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions test/DemaConsulting.ReqStream.Tests/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// Copyright (c) 2026 DEMA Consulting
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in all
// copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.

using Microsoft.VisualStudio.TestTools.UnitTesting;

/// <summary>
/// Configure test parallelization for the test assembly.
/// Tests are configured to run in parallel at the class level for better performance.
/// </summary>
[assembly: Parallelize(Workers = 0, Scope = ExecutionScope.ClassLevel)]
10 changes: 5 additions & 5 deletions test/DemaConsulting.ReqStream.Tests/ProgramTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ public void Run_WithVersionFlag_PrintsVersion()
var outputText = output.ToString().Trim();
// Version should be printed alone without any other text
Assert.IsFalse(string.IsNullOrWhiteSpace(outputText));
Assert.IsFalse(outputText.Contains("Copyright"));
Assert.IsFalse(outputText.Contains("Usage"));
Assert.DoesNotContain("Copyright", outputText);
Assert.DoesNotContain("Usage", outputText);
}
finally
{
Expand Down Expand Up @@ -276,8 +276,8 @@ public void Run_WithVersionAndHelp_ProcessesVersionFirst()
var outputText = output.ToString().Trim();
// Version should be printed alone
Assert.IsFalse(string.IsNullOrWhiteSpace(outputText));
Assert.IsFalse(outputText.Contains("Usage:"));
Assert.IsFalse(outputText.Contains("Copyright"));
Assert.DoesNotContain("Usage:", outputText);
Assert.DoesNotContain("Copyright", outputText);
}
finally
{
Expand All @@ -302,7 +302,7 @@ public void Run_WithHelpAndValidate_ProcessesHelpFirst()

var outputText = output.ToString();
StringAssert.Contains(outputText, "Usage:");
Assert.IsFalse(outputText.Contains("Self-validation"));
Assert.DoesNotContain("Self-validation", outputText);
}
finally
{
Expand Down
50 changes: 25 additions & 25 deletions test/DemaConsulting.ReqStream.Tests/RequirementsParsingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ public void Read_SimpleRequirement_ParsesCorrectly()
var requirements = Requirements.Read(filePath);

Assert.IsNotNull(requirements);
Assert.AreEqual(1, requirements.Sections.Count);
Assert.HasCount(1, requirements.Sections);
Assert.AreEqual("System Security", requirements.Sections[0].Title);
Assert.AreEqual(1, requirements.Sections[0].Requirements.Count);
Assert.HasCount(1, requirements.Sections[0].Requirements);
Assert.AreEqual("SYS-SEC-001", requirements.Sections[0].Requirements[0].Id);
Assert.AreEqual("The system shall support credentials authentication.", requirements.Sections[0].Requirements[0].Title);
}
Expand Down Expand Up @@ -101,7 +101,7 @@ public void Read_RequirementWithTests_ParsesTestsCorrectly()
Assert.IsNotNull(requirements);
var req = requirements.Sections[0].Requirements[0];
Assert.AreEqual("AUTH-001", req.Id);
Assert.AreEqual(3, req.Tests.Count);
Assert.HasCount(3, req.Tests);
Assert.AreEqual("Credentials_Valid_Allowed", req.Tests[0]);
Assert.AreEqual("Credentials_Invalid_Refused", req.Tests[1]);
Assert.AreEqual("Credentials_Missing_Refused", req.Tests[2]);
Expand Down Expand Up @@ -131,7 +131,7 @@ public void Read_RequirementWithChildren_ParsesChildrenCorrectly()
Assert.IsNotNull(requirements);
var req = requirements.Sections[0].Requirements[0];
Assert.AreEqual("SYS-SEC-001", req.Id);
Assert.AreEqual(2, req.Children.Count);
Assert.HasCount(2, req.Children);
Assert.AreEqual("AUTH-001", req.Children[0]);
Assert.AreEqual("AUTH-002", req.Children[1]);
}
Expand Down Expand Up @@ -161,9 +161,9 @@ public void Read_NestedSections_ParsesHierarchyCorrectly()
var requirements = Requirements.Read(filePath);

Assert.IsNotNull(requirements);
Assert.AreEqual(1, requirements.Sections.Count);
Assert.HasCount(1, requirements.Sections);
Assert.AreEqual("Data Management", requirements.Sections[0].Title);
Assert.AreEqual(2, requirements.Sections[0].Sections.Count);
Assert.HasCount(2, requirements.Sections[0].Sections);
Assert.AreEqual("User Authentication", requirements.Sections[0].Sections[0].Title);
Assert.AreEqual("Logging", requirements.Sections[0].Sections[1].Title);
Assert.AreEqual("AUTH-001", requirements.Sections[0].Sections[0].Requirements[0].Id);
Expand Down Expand Up @@ -197,7 +197,7 @@ public void Read_TestMappings_AppliesMappingsCorrectly()
Assert.IsNotNull(requirements);
var req = requirements.Sections[0].Requirements[0];
Assert.AreEqual("DATA-001", req.Id);
Assert.AreEqual(2, req.Tests.Count);
Assert.HasCount(2, req.Tests);
Assert.AreEqual("Logging_ValidRequest_Logged", req.Tests[0]);
Assert.AreEqual("Logging_InvalidRequest_Logged", req.Tests[1]);
}
Expand Down Expand Up @@ -233,7 +233,7 @@ public void Read_WithIncludes_MergesFilesCorrectly()
var requirements = Requirements.Read(mainPath);

Assert.IsNotNull(requirements);
Assert.AreEqual(2, requirements.Sections.Count);
Assert.HasCount(2, requirements.Sections);
Assert.AreEqual("System Security", requirements.Sections[0].Title);
Assert.AreEqual("Data Management", requirements.Sections[1].Title);
Assert.AreEqual("SYS-SEC-001", requirements.Sections[0].Requirements[0].Id);
Expand Down Expand Up @@ -271,9 +271,9 @@ public void Read_IdenticalSections_MergesCorrectly()
var requirements = Requirements.Read(mainPath);

Assert.IsNotNull(requirements);
Assert.AreEqual(1, requirements.Sections.Count);
Assert.HasCount(1, requirements.Sections);
Assert.AreEqual("System Security", requirements.Sections[0].Title);
Assert.AreEqual(2, requirements.Sections[0].Requirements.Count);
Assert.HasCount(2, requirements.Sections[0].Requirements);
Assert.AreEqual("SYS-SEC-001", requirements.Sections[0].Requirements[0].Id);
Assert.AreEqual("SYS-SEC-002", requirements.Sections[0].Requirements[1].Id);
}
Expand Down Expand Up @@ -342,7 +342,7 @@ public void Read_IncludeLoop_DoesNotCauseInfiniteLoop()
var requirements = Requirements.Read(pathA);

Assert.IsNotNull(requirements);
Assert.AreEqual(2, requirements.Sections.Count);
Assert.HasCount(2, requirements.Sections);
}

/// <summary>
Expand Down Expand Up @@ -378,8 +378,8 @@ public void Read_EmptyFile_ReturnsEmptyRequirements()
var requirements = Requirements.Read(filePath);

Assert.IsNotNull(requirements);
Assert.AreEqual(0, requirements.Sections.Count);
Assert.AreEqual(0, requirements.Requirements.Count);
Assert.IsEmpty(requirements.Sections);
Assert.IsEmpty(requirements.Requirements);
}

/// <summary>
Expand Down Expand Up @@ -425,28 +425,28 @@ public void Read_ComplexStructure_ParsesCorrectly()
var requirements = Requirements.Read(filePath);

Assert.IsNotNull(requirements);
Assert.AreEqual(2, requirements.Sections.Count);
Assert.HasCount(2, requirements.Sections);

var sysSec = requirements.Sections[0];
Assert.AreEqual("System Security", sysSec.Title);
Assert.AreEqual(1, sysSec.Requirements.Count);
Assert.HasCount(1, sysSec.Requirements);
Assert.AreEqual("SYS-SEC-001", sysSec.Requirements[0].Id);
Assert.AreEqual(1, sysSec.Requirements[0].Children.Count);
Assert.HasCount(1, sysSec.Requirements[0].Children);
Assert.AreEqual("AUTH-001", sysSec.Requirements[0].Children[0]);

var dataManagement = requirements.Sections[1];
Assert.AreEqual("Data Management", dataManagement.Title);
Assert.AreEqual(2, dataManagement.Sections.Count);
Assert.HasCount(2, dataManagement.Sections);

var auth = dataManagement.Sections[0];
Assert.AreEqual("User Authentication", auth.Title);
Assert.AreEqual("AUTH-001", auth.Requirements[0].Id);
Assert.AreEqual(3, auth.Requirements[0].Tests.Count);
Assert.HasCount(3, auth.Requirements[0].Tests);

var logging = dataManagement.Sections[1];
Assert.AreEqual("Logging", logging.Title);
Assert.AreEqual("DATA-001", logging.Requirements[0].Id);
Assert.AreEqual(2, logging.Requirements[0].Tests.Count);
Assert.HasCount(2, logging.Requirements[0].Tests);
Assert.AreEqual("Logging_ValidRequest_Logged", logging.Requirements[0].Tests[0]);
}

Expand Down Expand Up @@ -705,7 +705,7 @@ public void Read_MultipleFiles_MergesAllFiles()
var requirements = Requirements.Read(file1Path, file2Path, file3Path);

Assert.IsNotNull(requirements);
Assert.AreEqual(3, requirements.Sections.Count);
Assert.HasCount(3, requirements.Sections);
Assert.AreEqual("System Security", requirements.Sections[0].Title);
Assert.AreEqual("Data Management", requirements.Sections[1].Title);
Assert.AreEqual("Performance", requirements.Sections[2].Title);
Expand Down Expand Up @@ -742,9 +742,9 @@ public void Read_MultipleFilesWithSameSections_MergesSections()
var requirements = Requirements.Read(file1Path, file2Path);

Assert.IsNotNull(requirements);
Assert.AreEqual(1, requirements.Sections.Count);
Assert.HasCount(1, requirements.Sections);
Assert.AreEqual("System Security", requirements.Sections[0].Title);
Assert.AreEqual(2, requirements.Sections[0].Requirements.Count);
Assert.HasCount(2, requirements.Sections[0].Requirements);
Assert.AreEqual("SYS-SEC-001", requirements.Sections[0].Requirements[0].Id);
Assert.AreEqual("SYS-SEC-002", requirements.Sections[0].Requirements[1].Id);
}
Expand All @@ -768,9 +768,9 @@ public void Read_SingleFileWithParamsArray_WorksCorrectly()
var requirements = Requirements.Read(filePath);

Assert.IsNotNull(requirements);
Assert.AreEqual(1, requirements.Sections.Count);
Assert.HasCount(1, requirements.Sections);
Assert.AreEqual("System Security", requirements.Sections[0].Title);
Assert.AreEqual(1, requirements.Sections[0].Requirements.Count);
Assert.HasCount(1, requirements.Sections[0].Requirements);
Assert.AreEqual("SYS-SEC-001", requirements.Sections[0].Requirements[0].Id);
}

Expand Down Expand Up @@ -799,7 +799,7 @@ public void Read_NullArgument_ThrowsArgumentException()
{
try
{
Requirements.Read(null);
Requirements.Read(null!);
Assert.Fail("Expected ArgumentException was not thrown");
}
catch (ArgumentException ex)
Expand Down
50 changes: 25 additions & 25 deletions test/DemaConsulting.ReqStream.Tests/RequirementsReadTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ public void Read_SimpleRequirement_ParsesCorrectly()
var requirements = Requirements.Read(filePath);

Assert.IsNotNull(requirements);
Assert.AreEqual(1, requirements.Sections.Count);
Assert.HasCount(1, requirements.Sections);
Assert.AreEqual("System Security", requirements.Sections[0].Title);
Assert.AreEqual(1, requirements.Sections[0].Requirements.Count);
Assert.HasCount(1, requirements.Sections[0].Requirements);
Assert.AreEqual("SYS-SEC-001", requirements.Sections[0].Requirements[0].Id);
Assert.AreEqual("The system shall support credentials authentication.", requirements.Sections[0].Requirements[0].Title);
}
Expand Down Expand Up @@ -101,7 +101,7 @@ public void Read_RequirementWithTests_ParsesTestsCorrectly()
Assert.IsNotNull(requirements);
var req = requirements.Sections[0].Requirements[0];
Assert.AreEqual("AUTH-001", req.Id);
Assert.AreEqual(3, req.Tests.Count);
Assert.HasCount(3, req.Tests);
Assert.AreEqual("Credentials_Valid_Allowed", req.Tests[0]);
Assert.AreEqual("Credentials_Invalid_Refused", req.Tests[1]);
Assert.AreEqual("Credentials_Missing_Refused", req.Tests[2]);
Expand Down Expand Up @@ -131,7 +131,7 @@ public void Read_RequirementWithChildren_ParsesChildrenCorrectly()
Assert.IsNotNull(requirements);
var req = requirements.Sections[0].Requirements[0];
Assert.AreEqual("SYS-SEC-001", req.Id);
Assert.AreEqual(2, req.Children.Count);
Assert.HasCount(2, req.Children);
Assert.AreEqual("AUTH-001", req.Children[0]);
Assert.AreEqual("AUTH-002", req.Children[1]);
}
Expand Down Expand Up @@ -161,9 +161,9 @@ public void Read_NestedSections_ParsesHierarchyCorrectly()
var requirements = Requirements.Read(filePath);

Assert.IsNotNull(requirements);
Assert.AreEqual(1, requirements.Sections.Count);
Assert.HasCount(1, requirements.Sections);
Assert.AreEqual("Data Management", requirements.Sections[0].Title);
Assert.AreEqual(2, requirements.Sections[0].Sections.Count);
Assert.HasCount(2, requirements.Sections[0].Sections);
Assert.AreEqual("User Authentication", requirements.Sections[0].Sections[0].Title);
Assert.AreEqual("Logging", requirements.Sections[0].Sections[1].Title);
Assert.AreEqual("AUTH-001", requirements.Sections[0].Sections[0].Requirements[0].Id);
Expand Down Expand Up @@ -197,7 +197,7 @@ public void Read_TestMappings_AppliesMappingsCorrectly()
Assert.IsNotNull(requirements);
var req = requirements.Sections[0].Requirements[0];
Assert.AreEqual("DATA-001", req.Id);
Assert.AreEqual(2, req.Tests.Count);
Assert.HasCount(2, req.Tests);
Assert.AreEqual("Logging_ValidRequest_Logged", req.Tests[0]);
Assert.AreEqual("Logging_InvalidRequest_Logged", req.Tests[1]);
}
Expand Down Expand Up @@ -233,7 +233,7 @@ public void Read_WithIncludes_MergesFilesCorrectly()
var requirements = Requirements.Read(mainPath);

Assert.IsNotNull(requirements);
Assert.AreEqual(2, requirements.Sections.Count);
Assert.HasCount(2, requirements.Sections);
Assert.AreEqual("System Security", requirements.Sections[0].Title);
Assert.AreEqual("Data Management", requirements.Sections[1].Title);
Assert.AreEqual("SYS-SEC-001", requirements.Sections[0].Requirements[0].Id);
Expand Down Expand Up @@ -271,9 +271,9 @@ public void Read_IdenticalSections_MergesCorrectly()
var requirements = Requirements.Read(mainPath);

Assert.IsNotNull(requirements);
Assert.AreEqual(1, requirements.Sections.Count);
Assert.HasCount(1, requirements.Sections);
Assert.AreEqual("System Security", requirements.Sections[0].Title);
Assert.AreEqual(2, requirements.Sections[0].Requirements.Count);
Assert.HasCount(2, requirements.Sections[0].Requirements);
Assert.AreEqual("SYS-SEC-001", requirements.Sections[0].Requirements[0].Id);
Assert.AreEqual("SYS-SEC-002", requirements.Sections[0].Requirements[1].Id);
}
Expand Down Expand Up @@ -342,7 +342,7 @@ public void Read_IncludeLoop_DoesNotCauseInfiniteLoop()
var requirements = Requirements.Read(pathA);

Assert.IsNotNull(requirements);
Assert.AreEqual(2, requirements.Sections.Count);
Assert.HasCount(2, requirements.Sections);
}

/// <summary>
Expand Down Expand Up @@ -378,8 +378,8 @@ public void Read_EmptyFile_ReturnsEmptyRequirements()
var requirements = Requirements.Read(filePath);

Assert.IsNotNull(requirements);
Assert.AreEqual(0, requirements.Sections.Count);
Assert.AreEqual(0, requirements.Requirements.Count);
Assert.IsEmpty(requirements.Sections);
Assert.IsEmpty(requirements.Requirements);
}

/// <summary>
Expand Down Expand Up @@ -425,28 +425,28 @@ public void Read_ComplexStructure_ParsesCorrectly()
var requirements = Requirements.Read(filePath);

Assert.IsNotNull(requirements);
Assert.AreEqual(2, requirements.Sections.Count);
Assert.HasCount(2, requirements.Sections);

var sysSec = requirements.Sections[0];
Assert.AreEqual("System Security", sysSec.Title);
Assert.AreEqual(1, sysSec.Requirements.Count);
Assert.HasCount(1, sysSec.Requirements);
Assert.AreEqual("SYS-SEC-001", sysSec.Requirements[0].Id);
Assert.AreEqual(1, sysSec.Requirements[0].Children.Count);
Assert.HasCount(1, sysSec.Requirements[0].Children);
Assert.AreEqual("AUTH-001", sysSec.Requirements[0].Children[0]);

var dataManagement = requirements.Sections[1];
Assert.AreEqual("Data Management", dataManagement.Title);
Assert.AreEqual(2, dataManagement.Sections.Count);
Assert.HasCount(2, dataManagement.Sections);

var auth = dataManagement.Sections[0];
Assert.AreEqual("User Authentication", auth.Title);
Assert.AreEqual("AUTH-001", auth.Requirements[0].Id);
Assert.AreEqual(3, auth.Requirements[0].Tests.Count);
Assert.HasCount(3, auth.Requirements[0].Tests);

var logging = dataManagement.Sections[1];
Assert.AreEqual("Logging", logging.Title);
Assert.AreEqual("DATA-001", logging.Requirements[0].Id);
Assert.AreEqual(2, logging.Requirements[0].Tests.Count);
Assert.HasCount(2, logging.Requirements[0].Tests);
Assert.AreEqual("Logging_ValidRequest_Logged", logging.Requirements[0].Tests[0]);
}

Expand Down Expand Up @@ -705,7 +705,7 @@ public void Read_MultipleFiles_MergesAllFiles()
var requirements = Requirements.Read(file1Path, file2Path, file3Path);

Assert.IsNotNull(requirements);
Assert.AreEqual(3, requirements.Sections.Count);
Assert.HasCount(3, requirements.Sections);
Assert.AreEqual("System Security", requirements.Sections[0].Title);
Assert.AreEqual("Data Management", requirements.Sections[1].Title);
Assert.AreEqual("Performance", requirements.Sections[2].Title);
Expand Down Expand Up @@ -742,9 +742,9 @@ public void Read_MultipleFilesWithSameSections_MergesSections()
var requirements = Requirements.Read(file1Path, file2Path);

Assert.IsNotNull(requirements);
Assert.AreEqual(1, requirements.Sections.Count);
Assert.HasCount(1, requirements.Sections);
Assert.AreEqual("System Security", requirements.Sections[0].Title);
Assert.AreEqual(2, requirements.Sections[0].Requirements.Count);
Assert.HasCount(2, requirements.Sections[0].Requirements);
Assert.AreEqual("SYS-SEC-001", requirements.Sections[0].Requirements[0].Id);
Assert.AreEqual("SYS-SEC-002", requirements.Sections[0].Requirements[1].Id);
}
Expand All @@ -768,9 +768,9 @@ public void Read_SingleFileWithParamsArray_WorksCorrectly()
var requirements = Requirements.Read(filePath);

Assert.IsNotNull(requirements);
Assert.AreEqual(1, requirements.Sections.Count);
Assert.HasCount(1, requirements.Sections);
Assert.AreEqual("System Security", requirements.Sections[0].Title);
Assert.AreEqual(1, requirements.Sections[0].Requirements.Count);
Assert.HasCount(1, requirements.Sections[0].Requirements);
Assert.AreEqual("SYS-SEC-001", requirements.Sections[0].Requirements[0].Id);
}

Expand Down Expand Up @@ -799,7 +799,7 @@ public void Read_NullArgument_ThrowsArgumentException()
{
try
{
Requirements.Read(null);
Requirements.Read(null!);
Assert.Fail("Expected ArgumentException was not thrown");
}
catch (ArgumentException ex)
Expand Down
Loading