Skip to content

Add Dema Consulting icon to NuGet package#33

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/add-icon-to-nuget-package
Jan 27, 2026
Merged

Add Dema Consulting icon to NuGet package#33
Malcolmnixon merged 2 commits intomainfrom
copilot/add-icon-to-nuget-package

Conversation

Copy link
Contributor

Copilot AI commented Jan 26, 2026

Pull Request

Description

SarifMark NuGet package was missing the standard Dema Consulting branding icon. This adds the same Icon.png used across other Dema Consulting packages.

Changes:

  • Added Icon.png (128x128 PNG, 3.8KB) to repository root
  • Configured PackageIcon property in .csproj
  • Added icon to NuGet package contents via <None Include> directive

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

References the feature request for adding NuGet package icon.

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint '**/*.{yml,yaml}'

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

Icon sourced from demaconsulting/SonarMark repository for brand consistency. Package metadata configuration follows NuGet best practices for embedding package icons.

Original prompt

This section details on the original issue you should resolve

<issue_title>[Feature]: Add Icon to NuGet package</issue_title>
<issue_description>### Problem Statement

The SarifMark is missing its icon.

Proposed Solution

Copy the Dema Consuilting Icon.png from https://github.com/demaconsulting/SonarMark and then include it as the NuGet package icon.

Alternatives Considered

No response

Usage Examples

Benefits

Standard branding for Dema Consulting packages.

Priority

Low - Nice to have

Willingness to Contribute

Yes, I can submit a pull request

Additional Context

No response

Checklist

  • I have searched existing issues to ensure this is not a duplicate
  • I have provided a clear description of the feature
  • I have explained why this feature would be useful</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Add icon to NuGet package for SarifMark Add Dema Consulting icon to NuGet package Jan 26, 2026
Copilot AI requested a review from Malcolmnixon January 26, 2026 19:15
@Malcolmnixon Malcolmnixon marked this pull request as ready for review January 26, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add Icon to NuGet package

2 participants