Skip to content

Run project agents: repo consistency, code quality, requirements, docs, and code improvements#141

Merged
Malcolmnixon merged 9 commits intomainfrom
copilot/run-repo-consistency-agent
Feb 19, 2026
Merged

Run project agents: repo consistency, code quality, requirements, docs, and code improvements#141
Malcolmnixon merged 9 commits intomainfrom
copilot/run-repo-consistency-agent

Conversation

Copy link
Contributor

Copilot AI commented Feb 19, 2026

Pull Request

Description

Ran all project agents against the repository to align with TemplateDotNetTool patterns and apply cross-cutting improvements.

Repo Consistency

  • .editorconfig: Simplified and aligned with template (file-scoped namespaces, expression-bodied members, CA diagnostic suppressions, enforced braces as warning)
  • .cspell.json: Merged and alphabetized word list
  • .gitignore: Added JetBrains, doc build artifacts, test results, temp file patterns
  • csproj: Added SBOM generation via Microsoft.Sbom.Targets, InternalsVisibleTo for test project
  • Added cross-platform build.sh/build.bat and lint.sh/lint.bat scripts
  • Fixed UTF-8 BOM and final newline across all source files

Brace Enforcement

  • Changed csharp_prefer_braces from true:suggestion to true:warning in .editorconfig
  • Added braces to all single-line if/else/for/foreach/while statements across the entire codebase to resolve all IDE0011 violations

Self-Validation Coverage (56% → 81%)

Four new self-validation tests covering previously untested commands:

  • ValidateDiagram.cs — Mermaid diagram generation
  • ValidateHash.cs — SHA256 hash generation/verification
  • ValidateToMarkdown.cs — Markdown summary generation
  • ValidateBasic.cs — Basic SPDX document validation

Documentation

  • Converted inline links → reference-style links in CONTRIBUTING.md, SECURITY.md, docs/guide/guide.md, docs/spdx-tool-and-sbom-tool.md, docs/spdx-tool-command-line.md
  • Fixed typo declaredatdeclared at in docs/spdx-tool-workflow-files.md

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint '**/*.{yml,yaml}'

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

  • 96 unit tests + 13 self-validation tests pass across net8.0/9.0/10.0
  • Microsoft.Sbom.Targets 4.1.5 checked against GitHub Advisory DB — no known vulnerabilities
  • Agent report files (AGENT_REPORT_*.md) are excluded via .gitignore and not tracked in the repository

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI and others added 7 commits February 19, 2026 16:43
- Update .editorconfig with modern C# code style rules
  - Add end_of_line = lf setting
  - Add file-scoped namespace enforcement
  - Add expression-bodied member preferences
  - Simplify and reorganize settings to match template
  - Change braces preference to suggestion for gradual adoption

- Restructure .cspell.json to match template format
  - Alphabetically sort and merge word lists
  - Add missing template words
  - Preserve SpdxTool-specific terms
  - Simplify ignorePaths

- Enhance .gitignore patterns
  - Add .idea/ directory for JetBrains Rider
  - Add comprehensive documentation build artifacts
  - Add test results patterns
  - Add VersionMark captures and temporary files

- Add SBOM configuration to csproj
  - Enable SBOM generation
  - Add Microsoft.Sbom.Targets package
  - Add InternalsVisibleTo for test project

- Add convenience build and lint scripts
  - Create build.sh and build.bat
  - Create lint.sh and lint.bat
  - Support both Unix/Linux and Windows platforms

All changes verified with successful build and test execution.
No breaking changes introduced.
- Add declaredat (SPDX metadata field)
- Add hotspots (security terminology)
- Add sandboxed (security terminology)
- Add UTF-8 BOM to files missing it
- Add final newlines to all source files
- Fix whitespace formatting issues
- Change charset to utf-8-bom to match existing code style

All files now pass dotnet format --verify-no-changes
…atterns

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
…alidate commands

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
…atterns

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Run repo consistency agent and improve other agents Run project agents: repo consistency, code quality, requirements, docs, and code improvements Feb 19, 2026
Copilot AI requested a review from Malcolmnixon February 19, 2026 17:32
…ions; remove agent report files from tracking

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants