Pre-release quality: fix formatting, sync documentation, restructure user guide, and port template improvements#145
Conversation
|
@copilot An additional release-cleanup task is to update the heading-structure of the user guide. The guide has all its headings under one Title-like root heading. This isn't needed for documents compiled to PDF as the title is populated from title.txt. Additionally Pandoc automatically creates a Table of Contents so the guide doesn't need its own navigation table in Markdown, and should start with an Introduction section containing a Purpose and Scope, and then the critical sections of the document should also be root-level markdown sections. |
- Fix trailing whitespace in ValidateDiagram.cs, ValidateHash.cs, ValidateToMarkdown.cs - Update docs/spdx-tool-command-line.md with missing CLI options and correct diagram command - Update README.md self-validation section with current test names and complete test list - Fix CONTRIBUTING.md release process to not reference non-existent CHANGELOG.md Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
…xample - Consolidate Introduction to contain only Purpose and Scope subsections - Merge Key Features content into Purpose paragraph (no longer separate subsection) - Simplify Scope to concise description (Pandoc auto-generates TOC, redundant list removed) - Update self-validation example with current test names (SpdxTool_* prefix) and all 13 tests Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Done in c968da6. Changes to
All major sections (Installation, Command-Line Usage, Core Commands, etc.) remain as root-level |
|
@copilot Please re-run the Repo Consistency agent to review the last 10-20 PRs of https://github.com/demaconsulting/TemplateDotNetTool and merge in any improvements. |
- PR template: "All tests pass" → "All unit tests pass", add self-validation checklist item, simplify yamllint command to `yamllint .` - CONTRIBUTING.md: Separate unit tests and self-validation tests sections, use --configuration Release consistently, add --framework net10.0 to self-validation commands - Test .csproj: Reorganize with section comments (Build Configuration, Test Framework Dependencies, Code Analysis Dependencies, Project References) matching TemplateDotNetTool pattern Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Reviewed the last 20 merged PRs from TemplateDotNetTool (#16–#37). Most improvements were already present in SpdxTool (build script unit tests, markdownlint MD025 disable, version tracking, build-docs reorganization, agent report exclusions, package-lock.json in .gitignore). Ported the remaining applicable changes in 40c05bd:
PRs not applicable: #18 (SafePathCombine — SpdxTool doesn't have this utility), #35 (test source filters — SpdxTool has no requirements.yaml), #37 (agent files — not accessible). |
Pull Request
Description
Pre-release sweep to fix code formatting violations, sync documentation with actual tool behavior, restructure the user guide heading hierarchy, and port structural improvements from TemplateDotNetTool.
Code formatting
ValidateDiagram.cs,ValidateHash.cs,ValidateToMarkdown.cs(caught bydotnet format)Documentation accuracy
docs/spdx-tool-command-line.md: Add 4 missing CLI options (-l/--log,-s/--silent,--validate,-r/--result); fixdiagramcommand to include[tools]paramREADME.md: Update self-validation example — old names (AddPackage) → current (SpdxTool_AddPackage), add 5 missing tests (Validate, Diagram, Hash, Ntia, ToMarkdown)CONTRIBUTING.md: Remove reference to non-existent CHANGELOG.md; project uses auto-generated build notesGithub→GitHubtypo indocs/spdx-tool-github-ci.mdsetup-dotnet@v4→v5,checkout@v4→v6)User guide restructure (
docs/guide/guide.md)title.txtfor PDF compilation)## Key Featuressubsection)table-of-contents: true, so the section-by-section bullet list was redundant)SpdxTool_*prefix) and all 13 testsPort improvements from TemplateDotNetTool (PRs #24, #27, #32)
yamllint .CONTRIBUTING.md: Separated unit tests and self-validation tests into distinct subsections with--configuration Releaseand--framework net10.0flags.csproj: Reorganized with section comments (Build Configuration,Test Framework Dependencies,Code Analysis Dependencies,Project References) matching TemplateDotNetTool patternType of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.SpdxTool --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint .Testing
Documentation
Additional Notes
No behavioral changes. Self-validation (13/13) and unit tests (96/96) all pass. CodeQL reports 0 alerts.
Reviewed TemplateDotNetTool PRs #16–#37. Most improvements were already present in SpdxTool. Ported remaining applicable changes from PRs #24, #27, and #32. PRs not applicable: #18 (SafePathCombine utility doesn't exist in SpdxTool), #35 (test source filters — SpdxTool has no requirements.yaml), #37 (agent file changes).
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.