Skip to content

Fix CodeQL warnings: Convert foreach loops to LINQ Select #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Malcolmnixon merged 2 commits into from
Jan 27, 2026
Merged

Fix CodeQL warnings: Convert foreach loops to LINQ Select #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cdd133
Initial plan
Copilot Jan 27, 2026
bb3c21f
Fix CodeQL warnings by converting foreach loops to LINQ Select
Copilot Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions src/DemaConsulting.TestResults/IO/JUnitSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,7 @@ public static string Serialize(TestResults results)
new XAttribute("name", results.Name));

// Add test suites for each class
foreach (var suiteGroup in testSuites)
{
var testSuite = CreateTestSuiteElement(suiteGroup);
root.Add(testSuite);
}
root.Add(testSuites.Select(CreateTestSuiteElement));

// Write the XML text
var doc = new XDocument(root);
Expand Down Expand Up @@ -98,11 +94,7 @@ private static XElement CreateTestSuiteElement(IGrouping<string, TestResult> sui
new XAttribute("time", suiteTests.Sum(t => t.Duration.TotalSeconds).ToString(TimeFormatString, CultureInfo.InvariantCulture)));

// Add test cases
foreach (var test in suiteTests)
{
var testCase = CreateTestCaseElement(test);
testSuite.Add(testCase);
}
testSuite.Add(suiteTests.Select(CreateTestCaseElement));

return testSuite;
}
Expand Down Expand Up @@ -239,12 +231,7 @@ public static TestResults Deserialize(string junitContents)
private static void ParseTestSuite(XElement testSuiteElement, TestResults results)
{
var testCaseElements = testSuiteElement.Elements("testcase");

foreach (var testCaseElement in testCaseElements)
{
var testResult = ParseTestCase(testCaseElement);
results.Results.Add(testResult);
}
results.Results.AddRange(testCaseElements.Select(ParseTestCase));
}

/// <summary>
Expand Down
14 changes: 2 additions & 12 deletions src/DemaConsulting.TestResults/IO/TrxSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,13 +127,7 @@ private static XElement CreateRootElement(TestResults results)
private static XElement CreateResultsElement(List<TestResult> testResults)
{
var resultsElement = new XElement(TrxNamespace + "Results");

foreach (var test in testResults)
{
var resultElement = CreateUnitTestResultElement(test);
resultsElement.Add(resultElement);
}

resultsElement.Add(testResults.Select(CreateUnitTestResultElement));
return resultsElement;
}

Expand Down Expand Up @@ -352,11 +346,7 @@ private static void ParseTestResults(XDocument doc, XmlNamespaceManager nsMgr, T
"/trx:TestRun/trx:Results/trx:UnitTestResult",
nsMgr);

foreach (var resultElement in resultElements)
{
var testResult = ParseTestResult(doc, nsMgr, resultElement);
results.Results.Add(testResult);
}
results.Results.AddRange(resultElements.Select(e => ParseTestResult(doc, nsMgr, e)));
}

/// <summary>
Expand Down