Skip to content

Align build.yaml shell settings with SarifMark#90

Merged
Malcolmnixon merged 4 commits intomainfrom
copilot/update-build-yaml-settings
Jan 28, 2026
Merged

Align build.yaml shell settings with SarifMark#90
Malcolmnixon merged 4 commits intomainfrom
copilot/update-build-yaml-settings

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

Pull Request

Description

The build-docs job runs on windows-latest where PowerShell is the default shell, but several steps use bash-specific syntax like $(date +'%Y-%m-%d') and commands like cat/echo. Added explicit shell: bash to these steps to match SarifMark's approach.

Steps updated:

  • 4 Pandoc HTML generation steps using $(date +'%Y-%m-%d') for date metadata
  • 2 Display steps using cat and echo for quality report output

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint '**/*.{yml,yaml}'

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

This change prevents potential failures on Windows runners where PowerShell would misinterpret bash syntax. Aligns with SarifMark's proven workflow pattern.

Original prompt

Please review https://github.com/demaconsulting/SarifMark and update the build.yaml to align with the same shell settings.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 3 commits January 28, 2026 13:53
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Update build.yaml to align with shell settings Align build.yaml shell settings with SarifMark Jan 28, 2026
Copilot AI requested a review from Malcolmnixon January 28, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants