Skip to content

Update SonarMark/SarifMark to 1.1.0 and add development tooling#91

Merged
Malcolmnixon merged 5 commits intomainfrom
copilot/update-sonar-mark-and-sarif-mark
Jan 28, 2026
Merged

Update SonarMark/SarifMark to 1.1.0 and add development tooling#91
Malcolmnixon merged 5 commits intomainfrom
copilot/update-sonar-mark-and-sarif-mark

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

Pull Request

Description

Updates analysis tools to latest versions and adds developer tooling consistent with SarifMark repository.

Tool Updates

  • SonarMark: 1.0.0 → 1.1.0
  • SarifMark: 1.0.1 → 1.1.0

Developer Tooling

  • build.bat/build.sh - One-step build and test execution
  • lint.bat/lint.sh - Code formatting, spell check, markdown lint
  • .vscode/tasks.json - Preconfigured build, test, clean, restore, lint, format tasks

Documentation Fixes

  • Corrected TestOutcome enum documentation (was missing 8 enum values)
  • Added helper scripts usage to README.md and CONTRIBUTING.md
  • Updated project structure in CONTRIBUTING.md

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint '**/*.{yml,yaml}'

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

No functional code changes. Configuration and tooling only. All 41 tests pass across .NET 8, 9, 10.

Custom agent reviews completed:

  • project-maintainer: Dependencies current, project health excellent
  • software-quality-enforcer: 99.37% test coverage, zero warnings
  • documentation-writer: Documentation accuracy verified
Original prompt

Please update to SonarMark 1.1.0 and SarifMark 1.1.0 then review the project for good practices, documentation, and quality. Don't commit any actual report files on the quality as they don't belong in the repo. You can however run custom agents to do targeted reviews and apply any necessary fixes.

A recent equivalent action on https://github.com/demaconsulting/SarifMark resulted in producing useful files (.vscode/tasks.json, build.bat, build.sh, lint.bat, lint.sh) which are probably a good idea to replicate here as part of the good practices improvements.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 3 commits January 28, 2026 17:40
…helper scripts

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
…tcome details

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Update SonarMark and SarifMark to version 1.1.0 Update SonarMark/SarifMark to 1.1.0 and implement centralized configuration Jan 28, 2026
Copilot AI requested a review from Malcolmnixon January 28, 2026 18:01
Copy link
Contributor

@Malcolmnixon Malcolmnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to have the .vscode/extensions.json, global.json, Directory.Build.props, Directory.Packages.props. Please remove these files then put the build and package properties back in the csproj files.

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 28, 2026

I'd prefer not to have the .vscode/extensions.json, global.json, Directory.Build.props, Directory.Packages.props. Please remove these files then put the build and package properties back in the csproj...

Done. Removed the centralized configuration files (.vscode/extensions.json, global.json, Directory.Build.props, Directory.Packages.props) and restored the build and package properties to the csproj files. All tests pass. (1cda6f8)

Copilot AI changed the title Update SonarMark/SarifMark to 1.1.0 and implement centralized configuration Update SonarMark/SarifMark to 1.1.0 and add development tooling Jan 28, 2026
Copilot AI requested a review from Malcolmnixon January 28, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants