Skip to content

Reorganize csproj files following SarifMark template#94

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/cleanup-csproj-file
Feb 5, 2026
Merged

Reorganize csproj files following SarifMark template#94
Malcolmnixon merged 2 commits intomainfrom
copilot/cleanup-csproj-file

Conversation

Copy link
Contributor

Copilot AI commented Feb 5, 2026

Pull Request

Description

Restructures both csproj files to follow the organizational pattern from the SarifMark repository. Properties are now grouped with semantic comments, and ContinuousIntegrationBuild uses an inline conditional instead of a separate PropertyGroup.

Main Library (DemaConsulting.TestResults.csproj):

  • Grouped properties: Target Framework → NuGet Package → Symbol Package → Code Quality
  • Moved ContinuousIntegrationBuild inline: Condition="'$(GITHUB_ACTIONS)' == 'true'"
  • Added RepositoryUrl property
  • Reordered PackageReferences (SourceLink first, analyzers alphabetically)
  • Simplified None items to use compact Pack attribute syntax

Test Project (DemaConsulting.TestResults.Tests.csproj):

  • Grouped properties: Target Framework → Test Project → Code Quality
  • Reordered PackageReferences consistently

All required code quality settings verified present: TreatWarningsAsErrors=true, EnforceCodeStyleInBuild=true, EnableNETAnalyzers=true, AnalysisLevel=latest.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Addresses feature request for csproj cleanup and standardization.

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint '**/*.{yml,yaml}'

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

No functional changes—purely organizational. Build output and behavior unchanged.

Original prompt

This section details on the original issue you should resolve

<issue_title>[Feature]: Csproj Cleanup</issue_title>
<issue_description>### Problem Statement

The csproj files should have options grouped for clarity

Proposed Solution

Follow the formatting template of https://github.com/demaconsulting/SarifMark/blob/main/src/DemaConsulting.SarifMark/DemaConsulting.SarifMark.csproj and in addition ensure the following settings:

  • TreatWarningsAsErrors = true
  • EnforceCodeStyleInBuild = true
  • EnableNETAnalyzers = true
  • AnalysisLevel = latest

And move the ContinuousIntegrationBuild into the main property group as show in the template.

Alternatives Considered

No response

Usage Examples

Benefits

Simpler configuration organization

Priority

Medium - Would improve my workflow

Willingness to Contribute

Yes, I can submit a pull request

Additional Context

No response

Checklist

  • I have searched existing issues to ensure this is not a duplicate
  • I have provided a clear description of the feature
  • I have explained why this feature would be useful</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Clean up csproj files for better clarity Reorganize csproj files following SarifMark template Feb 5, 2026
Copilot AI requested a review from Malcolmnixon February 5, 2026 12:20
@Malcolmnixon Malcolmnixon marked this pull request as ready for review February 5, 2026 12:25
@Malcolmnixon Malcolmnixon merged commit b1ee589 into main Feb 5, 2026
7 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/cleanup-csproj-file branch February 5, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Csproj Cleanup

2 participants