Pre-release cleanup: template alignment, guide accuracy and structure fixes#24
Conversation
|
@copilot An additional release-cleanup task is to update the heading-structure of the user guide. The guide has all its headings under one Title-like root heading. This isn't needed for documents compiled to PDF as the title is populated from title.txt. Additionally Pandoc automatically creates a Table of Contents so the guide doesn't need its own navigation table in Markdown, and should start with an Introduction section containing a Purpose and Scope, and then the critical sections of the document should also be root-level markdown sections. |
- Add end_of_line = lf to .editorconfig for template compliance - Add MD025: false to .markdownlint-cli2.jsonc for template compliance - Fix guide.md JSON format: use PascalCase field names, remove non-existent timestamp field - Fix guide.md markdown output format: remove incorrect "(All jobs)" suffix and <sub> tags - Update guide.md to show separate bullets per version group (matching actual code behavior) Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
- Remove redundant H1 title (title.txt provides it for PDF) - Add Introduction section with Purpose and Scope subsections - Promote all sections to root-level H1 headings - Follows same pattern as other compiled documents in the project Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Restructured the guide in 7d73b80. Removed the redundant Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot I believe you forgot to review and update the requirements.yaml file - specifically the enhanced instructions about test sources - and that probably means you forgot to review and update the corresponding agent changes (both the AGENTS.md and the special agent configuration markdown files). You seem to have missed synchronizing important content with the template. Please run the repo-consistency agent again and instruct it to look deeply - possibly even looking back at the last week of PR changes and making sure their content is appropriately applied to this repo. |
Add test source filter documentation to: - requirements.yaml: expanded comment block explaining source filter prefixes - AGENTS.md: new Test Source Filters section - .github/agents/requirements-agent.md: new Test Source Filters section - .github/agents/test-developer.md: new Test Source Filters and MSTest V4 Best Practices sections These sections were added in the template via PRs #35 and #32 and document the critical source filter prefix syntax (windows@, ubuntu@, net8.0@, dotnet8.x@, etc.) used in requirements.yaml test links. Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Synced in 87bde24. I compared against the template's recent PRs (#35 "Document test source filter syntax" and #32 "Port improvements from TemplateDotNetLibrary") and added the missing content:
All markdown lint and spell checks pass. |
|
@copilot Please re-run the repo-consistency agent and have it review the last 10-20 PRs from https://github.com/demaconsulting/TemplateDotNetTool merging in improvements. |
- repo-consistency-agent.md: Add "Tracking Template Evolution" section (from template PR #37) - .gitignore: Add generated documentation entries for requirements, justifications, tracematrix, quality, and buildnotes (from template PR #32) - pull_request_template.md: Fix yamllint command to use `yamllint .` (from template PR #27) Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Completed a deep comparison against the last 20 merged template PRs (#16–#37) in ec6fc6a. Found and applied 3 additional missing items:
The remaining template PRs were either already applied, workflow-specific (not applicable), or dependency bumps. All linting passes clean. |
Pull Request
Description
Ran all six specialized agents (repo-consistency, code-quality, requirements, technical-writer, software-developer, test-developer) and performed a deep comparison against the last 20 merged PRs (#16–#37) from the TemplateDotNetTool template repository. Actionable findings were fixed:
.editorconfig: Addedend_of_line = lfto[*]section — aligns with TemplateDotNetTool template.markdownlint-cli2.jsonc: Added"MD025": false— aligns with templatedocs/guide/guide.md: Fixed output format documentation that diverged from actual behavior:job-id,versions) and a non-existenttimestampfield — corrected to PascalCase (JobId,Versions) matchingSystem.Text.Jsonserialization of theVersionInforecord(All jobs)suffix for uniform versions — code emits version only, no suffix<sub>tags with multiple versions on one line — code emits separate bullets per version group with parenthesized job IDsdocs/guide/guide.md: Restructured heading hierarchy for Pandoc PDF compilation:# VersionMark User Guidetitle heading (title.txt provides it for PDF)# Introductionsection with## Purposeand## Scopesubsections, following the same pattern as other compiled documents in the project (requirements, quality, etc.)requirements.yaml: Added test source filter documentation block explaining source filter prefix syntax (windows@,ubuntu@,net8.0@,dotnet8.x@, etc.) — synced from template PR #35AGENTS.md: Added "Test Source Filters" section documenting all filter prefixes and their meaning.github/agents/requirements-agent.md: Added "Test Source Filters" section with warning to never remove these filters.github/agents/test-developer.md: Added "Test Source Filters" section and "MSTest V4 Best Practices" section — synced from template PRs #35 and #32.github/agents/repo-consistency-agent.md: Added "Tracking Template Evolution" section — a systematic 4-step workflow for reviewing recent template PRs and propagating improvements to downstream repos (synced from template PR #37).gitignore: Added generated documentation entries for requirements, justifications, tracematrix, quality, and buildnotes (synced from template PR #32).github/pull_request_template.md: Fixed yamllint command fromyamllint '**/*.{yml,yaml}'toyamllint .(synced from template PR #27)All other agents reported the codebase as release-ready with no required changes (101/101 tests passing, 0 build warnings, 37/42 requirements satisfied locally with remaining 5 requiring CI platform matrix by design).
Type of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.VersionMark --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint .Testing
Documentation
Additional Notes
No code changes — only configuration and documentation. Testing/test checkboxes are N/A for this PR.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.