fix(admin): all procedures really filtered by tags

demarches-simplifiees · Oct 14, 2024 · 5eaf103 · 5eaf103
1 parent 041e98f
commit 5eaf103
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/spec/controllers/administrateurs/procedures_controller_spec.rb b/spec/controllers/administrateurs/procedures_controller_spec.rb
@@ -291,17 +291,22 @@
 
       it 'returns procedure who contains at least one tag included in params' do
         get :all, params: { procedure_tag_names: ['environnement'] }
-        expect(assigns(:procedures).any? { |p| p.id == procedure.id }).to be_truthy
+        expect(assigns(:procedures).find { |p| p.id == procedure.id }).to be_present
       end
 
       it 'returns procedures who contains all tags included in params' do
         get :all, params: { procedure_tag_names: ['environnement', 'diplomatie'] }
-        expect(assigns(:procedures).any? { |p| p.id == procedure.id }).to be_truthy
+        expect(assigns(:procedures).find { |p| p.id == procedure.id }).to be_present
       end
 
       it 'returns the procedure when at least one tag is include' do
         get :all, params: { procedure_tag_names: ['environnement', 'diplomatie', 'football'] }
-        expect(assigns(:procedures).any? { |p| p.id == procedure.id }).to be_truthy
+        expect(assigns(:procedures).find { |p| p.id == procedure.id }).to be_present
+      end
+
+      it 'does not return procedure not having the queried tag' do
+        get :all, params: { procedure_tag_names: ['football'] }
+        expect(assigns(:procedures)).to be_empty
       end
     end