Merge pull request #9880 from demarches-simplifiees/api_token_store_l…

…ast_used_ips

API: stocke les ips utilisées pour accéder à l'API

app/controllers/api/v2/base_controller.rb

@@ -41,6 +41,7 @@ def authenticate_from_token
 
     if @api_token.present?
       @api_token.touch(:last_v2_authenticated_at)
+      @api_token.store_new_ip(request.remote_ip)
       @current_user = @api_token.administrateur.user
       Current.user = @current_user
     end

app/controllers/api_controller.rb

@@ -29,6 +29,7 @@ def authenticate_from_token
 
     if @api_token.present?
       @api_token.touch(:last_v1_authenticated_at)
+      @api_token.store_new_ip(request.remote_ip)
       @current_user = @api_token.administrateur.user
     end
   end

app/models/api_token.rb

@@ -58,6 +58,13 @@ def prefix
     Base64.urlsafe_encode64(id).slice(0, 5)
   end
 
+  def store_new_ip(ip)
+    set = Set.new(stored_ips)
+    if set.add?(IPAddr.new(ip))
+      update!(stored_ips: set.to_a)
+    end
+  end
+
   class << self
     def generate(administrateur)
       plain_token = generate_unique_secure_token

db/migrate/20231221142727_add_last_used_ips_column_to_api_token.rb

@@ -0,0 +1,5 @@
+class AddLastUsedIpsColumnToAPIToken < ActiveRecord::Migration[7.0]
+  def change
+    add_column :api_tokens, :stored_ips, :inet, array: true, default: []
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.0].define(version: 2023_11_28_071043) do
+ActiveRecord::Schema[7.0].define(version: 2023_12_21_142727) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "pgcrypto"
   enable_extension "plpgsql"
@@ -98,6 +98,7 @@
     t.datetime "last_v1_authenticated_at"
     t.datetime "last_v2_authenticated_at"
     t.string "name", null: false
+    t.inet "stored_ips", default: [], array: true
     t.datetime "updated_at", null: false
     t.integer "version", default: 3, null: false
     t.boolean "write_access", default: true, null: false

spec/models/api_token_spec.rb

@@ -157,4 +157,24 @@
       it { is_expected.to be_nil }
     end
   end
+
+  describe '#store_new_ip' do
+    let(:api_token) { APIToken.generate(administrateur).first }
+    let(:ip) { '192.168.0.1' }
+
+    subject do
+      api_token.store_new_ip(ip)
+      api_token.stored_ips
+    end
+
+    context 'when none ip is stored' do
+      it { is_expected.to eq([IPAddr.new(ip)]) }
+    end
+
+    context 'when the ip is already stored' do
+      before { api_token.update!(stored_ips: [ip]) }
+
+      it { is_expected.to eq([IPAddr.new(ip)]) }
+    end
+  end
 end