Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amélioration de la hiérarchie de titres sur les pages de listing et suppression d'un lien vide #10393

Merged
merged 6 commits into from
May 13, 2024

Conversation

inseo
Copy link
Contributor

@inseo inseo commented May 2, 2024

Fix #10391 : Amélioration de la hiérarchie de titres

Partie Admin

Après
Capture d’écran 2024-05-02 à 16 33 08
Avant
Capture d’écran 2024-05-02 à 16 53 48

Partie Instructeur

Après
Capture d’écran 2024-05-02 à 16 34 29
Avant
Capture d’écran 2024-05-02 à 16 51 59

Partie Usager

Après
Capture d’écran 2024-05-02 à 16 35 55
Avant
Capture d’écran 2024-05-02 à 16 50 43

Partie Expert

Après
Capture d’écran 2024-05-02 à 16 36 56
Avant
Capture d’écran 2024-05-02 à 11 59 44

Fix #10392 : Suppression d'un lien vide

Après
Capture d’écran 2024-05-02 à 16 48 03

Avant
Capture d’écran 2024-05-02 à 16 44 17

Copy link

what-the-diff bot commented May 2, 2024

PR Summary

  • Refactor of styling on admin procedures page
    • The changes to procedure_admin.scss and procedures/_procedures_list.html.haml reflect a stylistic cleanup to make the page appearance more uniform and pleasant.
    • Modifications to the margin and certain heading elements to improve the visual structure of the page content.
  • Introduction of a new heading on procedures list page
    • On the procedures/index.html.haml page, a new heading titled "Mes démarches" has been inserted, offering better content organization and clarity for users.
  • Styling updates on expert feedback page
    • The changes in experts/avis/index.html.haml enhanced the appearance and readability of the page title by modifying the class of the heading element.
  • Improvements in procedure overview for instructeurs
    • For instructeurs/procedures/_list.html.haml and instructeurs/procedures/_synthese.html.haml files, changes are made to enhance text readability and interface interaction.
    • The surrounding link on procedure logos has been removed, and various heading elements have been reformatted to improve readability, thereby improving user interaction and experience.
  • Refactor of heading elements in instructeurs procedures and user dossiers
    • The changes in instructeurs/procedures/index.html.haml, users/dossiers/_deleted_dossiers_list.html.haml, and users/dossiers/_dossiers_list.html.haml are to enhance hierarchy and readability of the page content section by reshaping the heading elements.

In general, this PR introduces readability and navigability improvements to various pages by modifying page structures and applying uniform CSS rules.

@inseo inseo requested a review from marleneklok May 2, 2024 15:02
Copy link
Contributor

@mfo mfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quelques détails d'implem pour partager la connaissance mais sinon c'est top !

@inseo inseo force-pushed the fix-page-listing-titles branch from aaea985 to 907bc8d Compare May 7, 2024 14:28
@mfo mfo added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit ef4fb44 May 13, 2024
18 checks passed
@mfo mfo deleted the fix-page-listing-titles branch May 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants