Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page de contact - suppression des paragraphes vides #10414

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

inseo
Copy link
Contributor

@inseo inseo commented May 13, 2024

Après
Capture d’écran 2024-05-13 à 16 46 48

Avant
Capture d’écran 2024-05-13 à 16 45 20

Copy link

what-the-diff bot commented May 13, 2024

PR Summary

  • Modification in Callout Component Usage
    The Dsfr::CalloutComponent in the index.html.haml file has been tweaked. We've shifted from using c.with_body to c.with_html_body. This change will allow the Callout component to handle more complex content, such as content incorporating HTML tags, hence providing greater flexibility in content presentation.

Copy link
Member

@colinux colinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai l'impression que le texte va se retrouver complètement hors <p> car en regardant app/components/dsfr/callout_component/callout_component.html.haml :

  • soit with_body injecte le texte dans un <p> , donc jusqu'à présent ici ça faisait doublon et imbriquait 2 <p> (les navigateurs rattrapent le coup en fermant le premier avant d'ouvrir le second, ce qui conduit au <p> vide)
  • soit with_html_body le met tel quel (dans un div), mais alors c'est ici qu'il faudrait forcer le p. Cette variante a été prévue pour les cas où on veut mettre autre chose qu'un <p> autour du texte.

En résumé à moins que j'ai raté un truc, on devrait pouvoir garder .with_body mais sans le <p> ici

@mfo mfo enabled auto-merge May 24, 2024 08:19
@mfo mfo force-pushed the fix-contact-callout branch from e8ed4f2 to e866ace Compare May 24, 2024 08:19
@mfo mfo added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit c2c4c46 May 24, 2024
18 checks passed
@mfo mfo deleted the fix-contact-callout branch May 24, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants