Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech (carte): ignore silencieusement les params invalides #10422

Merged

Conversation

colinux
Copy link
Member

@colinux colinux commented May 15, 2024

Empêche d'envoyer une date invalide à PG et polluer les logs et sentry (vu via les tests YWH)

@colinux colinux requested a review from krichtof May 15, 2024 21:34
@colinux colinux changed the title Tech (carte): ignore proprement les params invalides Tech (carte): ignore silencieusement les params invalides May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (40e952e) to head (37bd68c).
Report is 28 commits behind head on main.

❗ Current head 37bd68c differs from pull request most recent head 3d52601. Consider uploading reports for the commit 3d52601 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #10422    +/-   ##
========================================
  Coverage   80.79%   80.80%            
========================================
  Files        1193     1197     +4     
  Lines       25143    25248   +105     
  Branches     4526     4545    +19     
========================================
+ Hits        20315    20402    +87     
- Misses       4828     4846    +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinux colinux force-pushed the better-sanitize-stats-year branch 3 times, most recently from 37bd68c to cfdfd60 Compare May 16, 2024 14:51
Empêche d'envoyer une date invalide à PG et polluer les logs.
@colinux colinux force-pushed the better-sanitize-stats-year branch from cfdfd60 to 3d52601 Compare May 16, 2024 14:58
Copy link
Contributor

@krichtof krichtof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top !

@colinux colinux added this pull request to the merge queue May 16, 2024
Merged via the queue into demarches-simplifiees:main with commit 55ee9cd May 16, 2024
16 checks passed
@colinux colinux deleted the better-sanitize-stats-year branch May 16, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants