Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ admin, créé les balises "date de mise à jour" du dossier et "date prévisionnelle SVA/SVR" #10812

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

colinux
Copy link
Member

@colinux colinux commented Sep 17, 2024

  • la balise date de mise à jour du dossier est toujours disponible
  • la balise date prévisionnelle SVA/SVR n'est disponible que pour les modèles d'emails d'un dossier qui n'est pas encore traité, (sauf accusé de réception, car la date n'est pas encore définie)

Closes #9825
Closes #10033

@colinux colinux force-pushed the date-last-updated-at-tag branch 2 times, most recently from e6d2f02 to 2b0234e Compare September 17, 2024 16:22
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.68%. Comparing base (5b268ff) to head (2b07826).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10812      +/-   ##
==========================================
+ Coverage   84.64%   84.68%   +0.03%     
==========================================
  Files        1132     1132              
  Lines       25084    25099      +15     
  Branches     4693     4703      +10     
==========================================
+ Hits        21233    21255      +22     
+ Misses       3851     3844       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinux colinux force-pushed the date-last-updated-at-tag branch from 2b0234e to 0e64638 Compare September 18, 2024 10:56
Copy link
Contributor

@E-L-T E-L-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça m'a l'air top. Mais en testant j'ai un cas qui semble ne pas fonctionner : sva activé sur la démarche / je teste la balise --date prévisionnelle SVA/SVR-- dans les mails / je vois la date affichée dans l'accusé de passage en instruction, mais pas dans l'accusé de réception

@colinux colinux force-pushed the date-last-updated-at-tag branch from 0e64638 to 2b07826 Compare September 24, 2024 09:28
Copy link
Contributor

@E-L-T E-L-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@colinux
Copy link
Member Author

colinux commented Sep 24, 2024

@E-L-T j'ai amendé pour retirer le tag de ce mail d'accusé de réception.
Dans une autre PR je vais voir comment ne plus envoyer cet email là pour le SVA et les démarches déclaratives car redondants avec les autres emails.

@colinux colinux added this pull request to the merge queue Sep 24, 2024
Merged via the queue into demarches-simplifiees:main with commit 99534ef Sep 24, 2024
18 checks passed
@colinux colinux deleted the date-last-updated-at-tag branch September 24, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants