Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech: nettoyage des listes déroulantes seconde partie #10826

Merged
merged 8 commits into from
Sep 30, 2024

Conversation

LeSim
Copy link
Member

@LeSim LeSim commented Sep 19, 2024

Attention le commit no more empty case casse le site si la tache remove_empty_options_from_drop_down_list n'a pas été jouée.

@LeSim LeSim force-pushed the drop_down_clean_second_part branch from 6db209e to b7cd4f5 Compare September 19, 2024 15:34
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.70%. Comparing base (4830769) to head (fb66434).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
app/models/champs/multiple_drop_down_list_champ.rb 50.00% 2 Missing ⚠️
...ponents/editable_champ/drop_down_list_component.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10826   +/-   ##
=======================================
  Coverage   84.69%   84.70%           
=======================================
  Files        1130     1130           
  Lines       25064    25055    -9     
  Branches     4701     4699    -2     
=======================================
- Hits        21228    21222    -6     
+ Misses       3836     3833    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeSim LeSim force-pushed the drop_down_clean_second_part branch from b7cd4f5 to c67355d Compare September 20, 2024 08:56
Copy link
Contributor

@mfo mfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bcp plus facile a lire, merci !

@LeSim LeSim force-pushed the drop_down_clean_second_part branch from c67355d to b5ff132 Compare September 30, 2024 13:36
@LeSim LeSim force-pushed the drop_down_clean_second_part branch from b5ff132 to fb66434 Compare September 30, 2024 13:37
@LeSim LeSim added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit ebb4763 Sep 30, 2024
18 checks passed
@LeSim LeSim deleted the drop_down_clean_second_part branch September 30, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants