tech: ETQ instructeur, ma page pour visualiser un dossier se charge plus vite #10899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10899 +/- ##
=======================================
Coverage 84.69% 84.69%
=======================================
Files 1130 1130
Lines 25082 25082
Branches 4706 4706
=======================================
Hits 21243 21243
Misses 3839 3839 ☔ View full report in Codecov by Sentry. |
mmagn
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Top ! effectivement sur skylight on était à l'agonie sur cet endpoint https://www.skylight.io/app/applications/zAvWTaqO0mu1/recent/6h/endpoints/Instructeurs::DossiersController%23show?responseType=html
mfo
force-pushed
the
US/fix-n-plus-one-on-instructeur-demande
branch
from
db01dd2 to
5cba847
Compare
Merged
via the queue into
demarches-simplifiees:main
with commit Oct 8, 2024
29500eb
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
En bossant sur la navigation instructeur je suis tombé sur une n+1 aux abords des types de champ/champs.
Ça impacter le Instructeurs/Dossiers#show, Users/Dossiers#show Users/Dossiers#edit... la base devrait être contente
apres :
avant :
