Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ ds, j'utilise le nouvel endpoint pour les API rnf #11114

Merged

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Dec 5, 2024

cf: https://secure.helpscout.net/conversation/2712331318/2095449

et oui, on ne vérifie pas l'host, car ça fait partie de la spec 🤯 ...

⚠️ AJOUT DE LA VAR D'ENV RNF_TOKEN ⚠️ @pengfeidong -> bon pr vous cette approche ?

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (2164d72) to head (cb2fd59).
Report is 84 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11114      +/-   ##
==========================================
+ Coverage   84.36%   84.40%   +0.03%     
==========================================
  Files        1181     1181              
  Lines       25997    26007      +10     
  Branches     4903     4904       +1     
==========================================
+ Hits        21933    21950      +17     
+ Misses       4064     4057       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tchak
Copy link
Member

tchak commented Dec 6, 2024

On n'avait pas dit qu'on refusait les API avec des protocoles ou des options de protocole pas très standards ? On ne peut pas pas résister un peu ? ssl_verifyhost: 0 c'est pas cool...

@mfo mfo requested a review from pengfeidong December 12, 2024 13:19
@mfo mfo added this pull request to the merge queue Dec 12, 2024
Merged via the queue into demarches-simplifiees:main with commit fe7c19f Dec 12, 2024
18 checks passed
@mfo mfo deleted the US/switch-to-new-rnf-api-endpoint branch December 12, 2024 14:57
Copy link

sentry-io bot commented Dec 16, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants