Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration(champs): remove non fillable champs and add repetition rows #11123

Merged

Conversation

tchak
Copy link
Member

@tchak tchak commented Dec 9, 2024

No description provided.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.48%. Comparing base (3ee386e) to head (6622d51).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...migrate_non_fillable_and_repetition_champs_task.rb 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11123   +/-   ##
=======================================
  Coverage   84.47%   84.48%           
=======================================
  Files        1185     1186    +1     
  Lines       26222    26240   +18     
  Branches     4942     4942           
=======================================
+ Hits        22152    22169   +17     
- Misses       4070     4071    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tchak tchak force-pushed the refactor-champs-migration-tasks branch from cdc582c to 6622d51 Compare December 16, 2024 12:21
@tchak tchak enabled auto-merge December 16, 2024 12:21
@tchak tchak added this pull request to the merge queue Dec 16, 2024
Merged via the queue into demarches-simplifiees:main with commit 6eb8982 Dec 16, 2024
18 checks passed
@tchak tchak deleted the refactor-champs-migration-tasks branch December 16, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants