Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajustement du design de l’interface instructeurs #11224

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ajustement du design de l’interface instructeurs #11224

wants to merge 1 commit into from
+9 −13

Conversation

kara22
Copy link
Contributor

@kara22 kara22 commented Jan 17, 2025

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.41%. Comparing base (7462bc4) to head (22728ce).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11224      +/-   ##
==========================================
- Coverage   84.41%   84.41%   -0.01%     
==========================================
  Files        1200     1200              
  Lines       26380    26378       -2     
  Branches     4965     4964       -1     
==========================================
- Hits        22269    22266       -3     
- Misses       4111     4112       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kara22 kara22 requested a review from marleneklok January 17, 2025 20:41
@marleneklok
Copy link

@kara22 Nickel sur les ajustements badges et "menu".
Reste à régler le bug responsive et ajouter le bandeau d'avertissement pour les démarches en test (mais c'est dans un autre ticket : #11216).

LeSim
LeSim approved these changes Jan 20, 2025
View reviewed changes
app/helpers/procedure_helper.rb
parts = procedure.brouillon? ? [procedure_badge(procedure)] : []
parts << procedure.libelle
safe_join(parts, ' ')
procedure.libelle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

du coup, est ce qu'on a encore besoin de cet helper 🤔 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeSim LeSim LeSim approved these changes

@marleneklok marleneklok Awaiting requested review from marleneklok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kara22 @marleneklok @LeSim