Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mailjet: i'm loving it #2787

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Mailjet: i'm loving it #2787

merged 1 commit into from
Oct 9, 2018

Conversation

LeSim
Copy link
Member

@LeSim LeSim commented Oct 9, 2018

No description provided.

gregoirenovel
gregoirenovel reviewed Oct 9, 2018
View reviewed changes
Copy link
Contributor

@gregoirenovel gregoirenovel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Suffixer tous les noms de tache par _emails, les vars d’env par _FILE, qu’on comprenne mieux
  • Limite j’aurais fait une méthode pour mutualiser les 9 premières lignes de chaque méthode
  • puts → rake_puts
  • ajouter la gestion des else aux if user.present? : rake_puts("user #{email} does not exist”) ?

@LeSim LeSim force-pushed the fix_mailjet_mistakes branch from e607e8e to e5a1e8c Compare October 9, 2018 15:53
@LeSim LeSim merged commit 59c0374 into dev Oct 9, 2018
@LeSim LeSim deleted the fix_mailjet_mistakes branch October 9, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregoirenovel gregoirenovel gregoirenovel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeSim @gregoirenovel