-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puma #2895
Conversation
@@ -171,7 +171,7 @@ group :development, :test do | |||
gem 'rspec-rails' | |||
|
|||
# Deploy | |||
gem 'mina', ref: '343a7', git: 'https://github.com/mina-deploy/mina.git' | |||
gem 'mina', git: 'https://github.com/mina-deploy/mina.git' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Y'a une bonne raison pour laquelle on tape encore sur la master et pas sur la dernière release ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je sais pas, faudra voir avec mat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A priori la version choisie par @mmagn a quelques commit de plus par rapport à la dernière release, je suppose qu’il y a quelque chose d’utile dedans ?
|
||
# Manually create these paths in shared/ (eg: shared/config/database.yml) in your server. | ||
# They will be linked in the 'deploy:link_shared_paths' step. | ||
set :shared_paths, [ | ||
'.env', | ||
set :shared_dirs, [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pourquoi on a encore ces trucs ? C'est pas casse-gueule ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nop, sur ces dossiers la, tu veux une continuité entre les différentes versions.
config/deploy.rb
Outdated
end | ||
|
||
namespace :service do | ||
desc "Manage services." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me semble pas que ça soit la bonne description de la tache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pas faux, je vais faire sauter toutes les descriptions.
lib/tasks/deploy.rake
Outdated
end | ||
end | ||
|
||
task :setup do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mettre cette tache avant le deploy ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j'ai l'impression que c'est fait dans les commits suivants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, fait dans #2901
to :launch do | ||
queue "/etc/init.d/#{user} upgrade " | ||
queue! %[sudo service delayed_job_#{user!} start] | ||
invoke :'rails:assets_precompile' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pourquoi on garde pas le :force
comme avant ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
il est passé en parametre de mina par la tache rake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes yes, je m'interroge sur la raison de ce changement :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.