Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prefill) Commune exemple #8843

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

guillett
Copy link
Contributor

@guillett guillett commented Apr 3, 2023

L'exemple donné pour le préremplissage d'un champ de commune n'est pas cohérent avec le texte. En effet, l'exemple indiqué un code postal et le texte le code département.

Avant
Screenshot 2023-04-03 at 16-38-32 Aide Beaumont-en-Verdunois · demarches-simplifiees fr

Après (normalement, j'avoue j'ai pas lancé en local)

Screenshot 2023-04-03 at 16-39-10 Aide Beaumont-en-Verdunois · demarches-simplifiees fr

@what-the-diff
Copy link

what-the-diff bot commented Apr 3, 2023

PR Summary

  • Changed example_value method output format
    The example_value method now returns a more structured output as an array, making it easier to work with. It contains two elements: the department code and the commune code, whereas previously it returned a single string with both codes separated by a comma.

@tchak
Copy link
Member

tchak commented Apr 3, 2023

C'est le text qu'il faut corriger. Ce qu'il faut passer c'est bien un code postal et un code INSEE.

@LeSim LeSim force-pushed the fix-commune-prefill branch from 672f7ed to d2891c5 Compare August 31, 2023 12:42
@LeSim LeSim enabled auto-merge August 31, 2023 12:43
@LeSim LeSim added this pull request to the merge queue Aug 31, 2023
Merged via the queue into demarches-simplifiees:main with commit dd85a49 Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants