Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actions multiples] Ajouter la possibilité pour les instructeurs de classer sans suite et refuser #9274

Merged
merged 9 commits into from
Jul 12, 2023

Conversation

lisa-durand
Copy link
Contributor

@lisa-durand lisa-durand commented Jul 3, 2023

closes #9224

Capture d’écran 2023-07-06 à 16 14 27 Capture d’écran 2023-07-06 à 16 14 42

@what-the-diff
Copy link

what-the-diff bot commented Jul 3, 2023

PR Summary

  • Inclusion of Three New Operations
    The BatchOperation model is now equipped with three new functions namely refuser, classer_sans_suite, and other for a broader set of tasks.

  • Inclusion of Translations for New Operations
    The new operations included in the BatchOperation model now come with translation support, thanks to enhancements made to the batch_operation_component translation files.

  • Induction of New Component with Translation Support
    A new component, batch_operation_inline_buttons_component, was incorporated, and its translations were added for better linguistic support.

  • Integration of New Operations into Dropdown Menu
    With the updates made to the batch_operation_component, new operations can now be accessed directly from a dropdown menu simplifying user interaction.

  • Manual Handling of Motivation and Justificatif Inputs
    A newly added partial, _instruction_button_motivation_batch.html.haml, allows users to manualy input motivation and justificatif elements during instruction operations.

  • Updates in View For Using Instruction Operations
    The batch_operation_component view has been modified to use the new partial for instruction operations, resulting in a more streamlined user experience.

  • Inclusion of New Instruction Operation into HTML File
    The batch_operation_component.html.haml file now includes the new instruction operation, thus incorporating more functionalities.

This PR primarily focuses on extending capabilities of the BatchOperation model and enhancing the interactions, thereby improving the overall user experience. Please note that alongside major updates, minor code cleanups and formatting changes have also been made for better readability and maintenance.

@lisa-durand lisa-durand force-pushed the bach-operation-all-instruction-actions branch from 6fa5ae9 to 3577bcb Compare July 4, 2023 09:13
@lisa-durand lisa-durand force-pushed the bach-operation-all-instruction-actions branch 2 times, most recently from 275c68d to f6a175d Compare July 6, 2023 12:21
@lisa-durand lisa-durand force-pushed the bach-operation-all-instruction-actions branch from f6a175d to ae55655 Compare July 6, 2023 14:12
@lisa-durand lisa-durand marked this pull request as ready for review July 6, 2023 14:22
@@ -58,6 +58,37 @@ export class BatchOperationController extends ApplicationController {
}
}

onSubmitInstruction(event: { srcElement: HTMLInputElement }) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai du faire ça ici car on a un formulaire unique pour les actions multiples, du coup on ne peut pas avoir un même champ avec le même id qui est "non required" (action "accepter") et "required (pour les actions "classer sans suite" et "refuser").

Copy link
Member

@colinux colinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niveau code rien de spéical c'est bien !

En testant je constate que le bouton "valider la décision" ne s'active pas, même pour "Accepter"
Y a aussi un petit padding bottom pas très heureux avec la bordure

Capture d’écran 2023-07-11 à 14 23 54

Copy link
Member

@LeSim LeSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mise a part les remarques de Colin, c'est hélas bon pour moi.

@lisa-durand lisa-durand added this pull request to the merge queue Jul 12, 2023
Merged via the queue into main with commit 3e30834 Jul 12, 2023
@lisa-durand lisa-durand deleted the bach-operation-all-instruction-actions branch July 12, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

En tant qu'instructeur, je veux pouvoir classer sans suite ou refuser des dossiers en masse.
3 participants