Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ Instructeur, je veux que les GeoJSON déposés par les utilisateurs soient valides #9275

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

tchak
Copy link
Member

@tchak tchak commented Jul 4, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Jul 4, 2023

PR Summary

  • Enhanced Validation Process
    Improved the validation process in the geographic information service (GeojsonService). This update will now execute a database query if the data in the common structure format (JSON) is valid. This addition can help prevent unnecessary data processing and enhance efficiency.

  • Initiated Geospatial Database Functionality
    Added a new update file (migration file) that enables the 'postgis' extension. This extension is important as it significantly improves the ability of our database to handle geographic objects. This means we can now better manipulate, analyze, and store geospatial data.

  • Updated Database Structure File
    Made changes to schema.rb (the database structure file) to reflect the addition of the 'postgis' extension. This will ensure coherent representation of the updates across the database.

  • Refined Testing Process
    Fixed a minor issue in the geographic area testing file (geo_area_spec.rb) by removing 'skip' from two test cases. This makes the testing process more comprehensive, raising the standard of quality assurance.

@tchak tchak force-pushed the validate-geo-json branch 5 times, most recently from a2a659f to 208a1a9 Compare July 4, 2023 14:01
@tchak tchak force-pushed the validate-geo-json branch 5 times, most recently from 4d6c165 to cd0686e Compare July 5, 2023 13:26
@tchak tchak force-pushed the validate-geo-json branch from cd0686e to d972ae1 Compare July 18, 2023 09:02
@tchak tchak force-pushed the validate-geo-json branch from d972ae1 to 735c504 Compare July 18, 2023 16:03
@tchak tchak enabled auto-merge July 18, 2023 16:03
@tchak tchak added this pull request to the merge queue Jul 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 18, 2023
@tchak tchak added this pull request to the merge queue Jul 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 18, 2023
@tchak tchak added this pull request to the merge queue Jul 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 18, 2023
@tchak tchak added this pull request to the merge queue Jul 19, 2023
Merged via the queue into demarches-simplifiees:main with commit 4f4e687 Jul 19, 2023
@tchak tchak deleted the validate-geo-json branch July 19, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants