Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql): add timestamps to files and champs #9306

Merged

Conversation

tchak
Copy link
Member

@tchak tchak commented Jul 12, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Jul 12, 2023

PR Summary

  • Introduction of an 'updatedAt' Field to Various GraphQL Types
    This update adds a new component, dubbed 'updatedAt', into numerous GraphQL types. This field, designed to hold dates and times in the ISO8601 format, aids in tracking the most recent modification times for several aspects such as address, cart, checkbox, etc.

  • Addition of an 'updatedAt' Field to the 'ChampType' GraphQL Type
    This change introduces a new 'updatedAt' field into the 'ChampType' GraphQL type, similarly intended to record the latest modification moment in the ISO8601 date-time format.

  • Inclusion of a 'created_at' Field to the 'File' GraphQL Type
    A new element, 'created_at', has been included to the 'File' GraphQL type. This field, which also uses the ISO8601 date-time format, is to log when a file first enters the system.

  • Changes in the 'dossier_type.rb' File
    The dossier_type.rb file has been altered to include the 'created_at' field for both 'pdf' and 'geojson' methods. This gives rise to a system-recognized timestamp for when a file was created, resulting in better organization and tracking of filed data.

Copy link
Contributor

@mfo mfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pas l'habitude des api graphql mais je suis surpris/déçu qu'il faille ajouter le updatedAt sur tous les type.
Ex: AddressChampDescriptor implements ChampDescriptor, j'aurais imaginé que le delcarer sur ChampDescriptor propagerait le truc.

@tchak tchak added this pull request to the merge queue Jul 13, 2023
Merged via the queue into demarches-simplifiees:main with commit 6958039 Jul 13, 2023
@tchak tchak deleted the graphql-champ-file-timestamp branch July 13, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants