Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amelioration(archive-uploader): capture avec sentry les erreurs du swift_wrapper #9328

Merged
merged 1 commit into from
Jul 19, 2023
Merged

amelioration(archive-uploader): capture avec sentry les erreurs du swift_wrapper #9328

merged 1 commit into from
Jul 19, 2023

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Jul 19, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Jul 19, 2023

PR Summary

  • Added Exception Handling to Archive Uploader
    The code has been updated to manage unexpected situations that might occur during a specific operation in the 'archive_uploader' section of our software. This means that if something goes wrong during the process, the software will attempt to carry out the operation again if reattempts are allowed. If this is not possible, it will report the issue for further investigation. This improvement ensures that our system can handle possible errors more robustly and minimize disruptions.

LeSim
LeSim approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@LeSim LeSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

viiiii

LeSim
LeSim approved these changes Jul 19, 2023
View reviewed changes
app/services/archive_uploader.rb Outdated
if limit_to_retry > 0
limit_to_retry = limit_to_retry - 1
retry
else
Sentry.capture_exception(e)
Copy link
Member

@LeSim LeSim Jul 19, 2023 •
edited by mfo
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Sentry.capture_exception(e)
Sentry.capture_exception(e, extra: { procedure:, filename: })

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

procedure on le met en tag car ça permet de filtrer contrairement aux extra

@mfo mfo force-pushed the US/reraise-error-on-archive-uploader branch from 74311b7 to b7603b3 Compare July 19, 2023 09:35
@LeSim LeSim force-pushed the US/reraise-error-on-archive-uploader branch from b7603b3 to e424cdf Compare July 19, 2023 09:52
@LeSim LeSim force-pushed the US/reraise-error-on-archive-uploader branch from e424cdf to 87abc79 Compare July 19, 2023 09:53
@LeSim LeSim enabled auto-merge July 19, 2023 09:53
@LeSim LeSim added this pull request to the merge queue Jul 19, 2023
Merged via the queue into demarches-simplifiees:main with commit 8fb6d00 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchak tchak tchak left review comments

@LeSim LeSim LeSim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
The Kanban
Status: Communiqué, ou a ne pas communiqué
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfo @tchak @LeSim