Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move submit en_construction logic to the model #9348

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

tchak
Copy link
Member

@tchak tchak commented Jul 24, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Jul 24, 2023

PR Summary

  • Introduction of a new method enhancing process handling
    A new code method called 'submit_en_construction!' was added to the Dossier model. This method simplifies certain sequential processes, such as transitioning to 'construction' status, saving file updates, computing routing, and resolving pending corrections if required. It also sets the 'conservation extension' attribute to 0 days, removing any extensions to this stage.

  • Refinement of the control mechanism
    The method 'submit_en_construction' within the DossiersController has been updated. It now utilizes the aforementioned 'submit_en_construction!' method, providing a more streamlined and efficient process control, replacing the previous logic which was less efficient.

@tchak tchak force-pushed the feat-submit-en-construction branch from 717acf5 to c2ffb11 Compare July 24, 2023 09:10
Copy link
Contributor

@E-L-T E-L-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tchak tchak force-pushed the feat-submit-en-construction branch from c2ffb11 to 93d6bda Compare July 24, 2023 10:13
@tchak tchak enabled auto-merge July 24, 2023 10:13
@tchak tchak added this pull request to the merge queue Jul 24, 2023
Merged via the queue into demarches-simplifiees:main with commit 1dfb381 Jul 24, 2023
@tchak tchak deleted the feat-submit-en-construction branch July 24, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants