Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ admin, je suis alerté lorsque mes demarches publiées ont des services sans siret ou pas de service #9353

Merged
merged 6 commits into from
Jul 27, 2023

Conversation

krichtof
Copy link
Contributor

close #9347

Avec cette PR, l'administrateur est alerté à chaque page si ses demarches publiées ont des services sans siret ou pas de service.

Capture d’écran 2023-07-24 à 19 33 49

@what-the-diff
Copy link

what-the-diff bot commented Jul 24, 2023

PR Summary

  • Improved System Alerts in Administrateur Controller
    The administrateur_controller has now new filters to alert administrators about missing data. Specifically, they notify if a service is missing a 'SIRET' or if a procedure is devoid of service.

  • Skip Alert Filters in Service Controller
    In the Service Controller, we've added exceptions to the alert system. This means administrators won't get bombarded with alerts for missing 'SIRET' or services while they're in the Service Controller.

  • Translations Added
    New translations have been added to both English and French for key alert contexts to enhance the user experience and help administrators understand the alert messages better.

  • Controller Specification Tests Added
    New verification tests have been integrated to ensure that these alerts are working correctly when a service doesn't have a 'SIRET' or a procedure lacks service. These tests are crucial for maintaining the system's stability and reliability.

@krichtof krichtof force-pushed the 9347-warning-siret branch 2 times, most recently from 3df6332 to 99cc931 Compare July 24, 2023 18:21
config/locales/fr.yml Outdated Show resolved Hide resolved
config/locales/fr.yml Outdated Show resolved Hide resolved
config/locales/fr.yml Outdated Show resolved Hide resolved
@krichtof krichtof force-pushed the 9347-warning-siret branch from ee1a1c4 to 048941e Compare July 25, 2023 08:49
@tchak tchak enabled auto-merge July 25, 2023 09:22
@tchak tchak force-pushed the 9347-warning-siret branch from 048941e to 60a7199 Compare July 25, 2023 10:49
@tchak tchak added this pull request to the merge queue Jul 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2023
@tchak tchak force-pushed the 9347-warning-siret branch 2 times, most recently from bca958f to 5623e37 Compare July 26, 2023 12:34
@tchak tchak enabled auto-merge July 26, 2023 12:34
krichtof and others added 6 commits July 27, 2023 10:08
Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
@krichtof krichtof force-pushed the 9347-warning-siret branch from 5623e37 to e28e31c Compare July 27, 2023 08:08
@tchak tchak added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit fed6b8c Jul 27, 2023
@tchak tchak deleted the 9347-warning-siret branch July 27, 2023 08:35
@Bouchralazaar
Copy link
Contributor

Super, étape 2 en septembre avec l'emailing des admin concernés :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETQ administrateur, je suis incité à renseigner le siret des services de mes démarches publiées
3 participants