Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commune): remove Paris, Marseille and Lyon top level insee code #9355

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

tchak
Copy link
Member

@tchak tchak commented Jul 25, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Jul 25, 2023

PR Summary

  • Updated method calls in api_geo_service.rb
    The methods communes_by_postal_code_map and get_from_api_geo in the api_geo_service.rb file have been updated to fetch data from a newer version of the cached data. This should ensure that they are now sourcing more up-to-date information.

  • Updated data in communes-75.json
    The values for several properties ("name", "code", "epci_code", "departement_code", and "postal_code") in the communes-75.json file have been corrected. These corrections will make sure the application uses the most accurate and latest data.

  • Filtering and data processing changes in api_geo_data.rake
    The way we process data in the api_geo_data.rake file has changed. Now, results with certain codes are excluded, ensuring that we only work with relevant data. We have also made updates on how the item data chunk is created to align with our updated data structure.

  • New rake task for removing toplevel communes
    A new file 20230725101602_remove_toplevel_communes.rake was added. This file contains a new task that will automate the process of prunning out unnecessary toplevel communes from our data during deployment. This improvement should streamline our deployment process and maintain the orderliness of our data structure.

@tchak tchak force-pushed the fix-communes branch 2 times, most recently from 98ad0e4 to 3cff4b4 Compare July 25, 2023 11:10
app/services/api_geo_service.rb Outdated Show resolved Hide resolved
@tchak tchak enabled auto-merge July 26, 2023 08:12
@tchak tchak added this pull request to the merge queue Jul 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 26, 2023
@tchak tchak added this pull request to the merge queue Jul 27, 2023
Merged via the queue into demarches-simplifiees:main with commit 7580279 Jul 27, 2023
@tchak tchak deleted the fix-communes branch July 27, 2023 06:14
@sentry-io
Copy link

sentry-io bot commented Jul 27, 2023

Suspect Issues

This pull request has been deployed and Sentry has observed the following issues:

  • ‼️ Redis::CannotConnectError: Connection refused - connect(2) for 192.168.33.121:6379 (Redis::CannotConnectError) Users::DossiersController#update View Issue
  • ‼️ Redis::CannotConnectError: Connection refused - connect(2) for 192.168.33.121:6379 (Redis::CannotConnectError) Users::DossiersController#update View Issue
  • ‼️ Redis::CannotConnectError: Connection refused - connect(2) for 192.168.33.121:6379 (Redis::CannotConnectError) Users::DossiersController#update View Issue
  • ‼️ Redis::CannotConnectError: Connection refused - connect(2) for 192.168.33.121:6379 (Redis::CannotConnectError) Champs::PieceJustificativeController#update View Issue
  • ‼️ Redis::CannotConnectError: Connection refused - connect(2) for 192.168.33.121:6379 (Redis::CannotConnectError) Users::DossiersController#update View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants