Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ Instructeur, je voudrais pouvoir créer des listes avec une numérotation personnalisée et sur plusieurs lignes #9364

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

tchak
Copy link
Member

@tchak tchak commented Jul 26, 2023

Cela corrige le problème au niveau du HTML en utilisant la technique : https://developer.mozilla.org/en-US/docs/Web/HTML/Element/li#ordered_list_with_a_custom_value

Mais le rendu est toujours incorrect. Je suppose qu'il y a un bug de CSS dans DSFR qui est trop agressif dans les styles des listes ? Si @mfo ou @colinux vous avez une idée je suis preneur :)

@what-the-diff
Copy link

what-the-diff bot commented Jul 26, 2023

PR Summary

  • Modification of SimpleFormatComponent Class
    The 'SimpleFormatComponent' class has been improved. Now it can better handle list items and can support an additional attribute called 'value'. Key modifications include modifications to the 'REDCARPET_EXTENSIONS' hash and the 'initialize' and 'attributes' methods.

  • Changes to BareRenderer Class
    The 'BareRenderer' class has been updated. It now includes a check for a number within a list item. If it finds one, it adds a 'value' attribute to the 'li' tag, offering custom list item handling.

  • Additions to Testing
    Several new test cases were added to the 'SimpleFormatComponent' class in the 'simple_format_component_spec.rb' file. These were designed to cover a variety of scenarios, such as dealing with numbered lists, multi-line lists and strong text.

In essence, these changes improve the logic around list handling and enable better formatting of text within the components.

@mfo
Copy link
Contributor

mfo commented Jul 27, 2023

c'est top Paul, ça va nous enlever du 'bruit au support' et faire du bien a nos usagers 🚀 !

j'ai fais un petit commit concernant la question du DSFR/listes numérotés : f2c1598

@mfo mfo force-pushed the fix-em-in-simple-format branch from 788a50b to f2c1598 Compare July 27, 2023 03:47
tchak and others added 2 commits July 27, 2023 09:07
@tchak tchak force-pushed the fix-em-in-simple-format branch from f2c1598 to fe712d6 Compare July 27, 2023 07:07
@tchak tchak enabled auto-merge July 27, 2023 07:08
@tchak tchak added this pull request to the merge queue Jul 27, 2023
Merged via the queue into demarches-simplifiees:main with commit fa278d5 Jul 27, 2023
@tchak tchak deleted the fix-em-in-simple-format branch July 27, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants