Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql): use camelize with inflection #9367

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

tchak
Copy link
Member

@tchak tchak commented Jul 27, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Jul 27, 2023

PR Summary

  • Addition of a New Parameter
    A new parameter $includeCorrections was introduced in the GraphQL API (file app/graphql/api/v2/stored_query.rb). This allows for flexibility when requesting data.

  • Inclusion of a New Field
    The field dateDerniereCorrectionEnAttente was added to our GraphQL API, enriching the data that can be accessed by users.

  • Standardization of Field Names
    Several fields in the GraphQL API were renamed to use standard capitalization for acronyms, such as URL instead of Url. Specifically, the fields demarcheUrl, cadreJuridiqueUrl, dpoUrl, noticeUrl, and siteWebUrl were renamed to demarcheURL, cadreJuridiqueURL, dpoURL, noticeURL, and siteWebURL respectively. These changes took place in various locations (app/graphql/api/v2/stored_query.rb, app/graphql/schema.graphql, app/graphql/types/demarche_descriptor_type.rb).

  • Deprecation of Old Field Names
    As part of the renaming process, some fields were marked as deprecated. This means that while they can still function for now to minimize disruption, they will eventually be phased out. To ensure compatibility, users are recommended to use the newly named fields.

  • Addition of a Camelize Module
    A new module was added in config/initializers/graphql.rb to handle the camelization of strings in GraphQL schema. This enhancement is intended to standardize how data is presented, making it easier for developers to work with GraphQL schema.

@tchak tchak force-pushed the graphql-camelize branch 2 times, most recently from 42890ac to b465be5 Compare July 27, 2023 10:19
@tchak tchak added this pull request to the merge queue Aug 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2023
@tchak tchak added this pull request to the merge queue Aug 1, 2023
@tchak tchak force-pushed the graphql-camelize branch from b465be5 to 0ca7249 Compare August 1, 2023 12:55
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2023
@tchak tchak added this pull request to the merge queue Aug 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2023
@tchak tchak added this pull request to the merge queue Aug 1, 2023
Merged via the queue into demarches-simplifiees:main with commit 3c309fb Aug 1, 2023
@tchak tchak deleted the graphql-camelize branch August 1, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants