Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Améliore l'affichage de plusieurs petits formulaires résiduels #9375

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

colinux
Copy link
Member

@colinux colinux commented Jul 31, 2023

Plusieurs forms à l'ancien design ont été plus ou moins visuellement cassés suite à l'intégration des erreurs au DSFR (cf #9004)

Cette PR transforme rapidement ces forms au DSFR, ou rajoute le margin manquant suivant les cas.
Il resterait idéalement à adapter l'éditeur des champs, mais c'est plus touchy vu son importance (plus de bordure sur le champ description)

Sur le form des services j'en ai profité pour remplacer les placeholders par les hints avec exemples.

Question bonus: l'InputComponent n'affiche pas (plus?) l'astérisque à côté du label quand il est required. Est-ce qu'on a un consensus (qui m'aurait échappé) pour l'enlever sur l'ensemble des formulaires ?

APRES

demarches-simplifiees-fr-services
Capture d’écran 2023-07-31 à 23 59 19
Capture d’écran 2023-07-31 à 23 57 50
Capture d’écran 2023-07-31 à 23 57 38
Capture d’écran 2023-08-01 à 00 02 22

AVANT

Capture d’écran 2023-08-01 à 00 02 09 Capture d’écran 2023-08-01 à 00 01 36 Capture d’écran 2023-08-01 à 00 01 07 Capture d’écran 2023-08-01 à 00 00 48

@colinux colinux changed the title Transforme plusieurs petits formulaires résiduels au DSFR Améliore l'affichage de plusieurs petits formulaires résiduels Jul 31, 2023
@what-the-diff
Copy link

what-the-diff bot commented Jul 31, 2023

PR Summary

  • Adjustments to layout and styles
    • Modifies certain screen elements in invitations form to display properly on larger screens by setting minimum width.
  • Enhancements to hint system
    • Adds an improved hint mechanism in errorable input components. The hint slot is looked for and a default hint is applied if not present.
  • Layout improvements in search component
    • Labelling and input for the search query now benefit from a more structured layout and an added hint text.
  • Email field enhancement in admin form
    • The email field now comes with more helpful hints and better organized layout.
  • Improved form positioning for adding an admin
    • The form for adding an admin was moved for better visibility and screen layout.
  • Improvements in procedures interface
    • Various interface elements in the procedures administration page have been restructured for better user experience. Some buttons are more visuals and some fields have more helpful hints.
  • Enhancements in service form
    • Refactors numerous labels and fields in service form to ensure a smoother experience and better understanding.
  • Invitations form-wide improvements
    • The layout, labelling and user experience of the invitations form has been greatly improved with organized fields and standardized buttons.
  • Layout improvements in users' profile
    • In the user's profile view, the email field and submit button have been modernized for ease of use.
  • Language pack updates
    • Language localization pack (fr.yml) is updated to include labels and hints for improved communication.

Please note that no changes were made to several files including index.html.haml, _monavis.html.haml, jeton.html.haml, monavis.html.haml, _form.html.haml, identite.html.haml, show.html.haml and fr.yml.

@tchak tchak added this pull request to the merge queue Aug 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2023
@tchak tchak added this pull request to the merge queue Aug 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2023
@tchak tchak added this pull request to the merge queue Aug 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2023
@tchak tchak added this pull request to the merge queue Aug 1, 2023
Merged via the queue into demarches-simplifiees:main with commit 9c8b015 Aug 1, 2023
@colinux colinux deleted the fix-legacy-forms-layout branch October 2, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants