Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dossier): removing options from multiselect should update conditions #9389

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

tchak
Copy link
Member

@tchak tchak commented Aug 3, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Aug 3, 2023

PR Summary

  • Inclusion of TurboChampsConcern in Champs::OptionsController
    We've added a new functionality, TurboChampsConcern, to the Champs::OptionsController class. This ensures your options work more effectively and leverages best practices.

  • Enhancements to 'remove' logic in Champs::OptionsController
    Updates have been made to the remove function within Champs::OptionsController. Changes include improved names for identifying the champ object and additional logic for managing display and update functionalities, thus increasing the function's efficiency.

  • Updated Templates for App Views
    Updates have been made to two parts of your user interface: champs/options and instructeurs/dossiers. We have integrated shared elements into both for uniformity and enhanced view rendering.

  • Creation of New Shared Component for Dossiers
    We've created a new shared component (file _update_champs.turbo_stream.haml) which acts as a template for updating and replacing specific parts of your user interface. This improves consistency and allows changes to be reflected globally.

  • Improved User Dossier Update Template
    An update to the users/dossiers part of your user interface ensures appropriate local data is passed when rendering shared components. This makes dossier updates smoother for the users.

@tchak tchak force-pushed the fix-update-champs branch from 7ef1100 to b5f7219 Compare August 3, 2023 15:05
@tchak tchak added the bug label Aug 3, 2023
@tchak tchak added this pull request to the merge queue Aug 8, 2023
Merged via the queue into demarches-simplifiees:main with commit 17cfc54 Aug 8, 2023
@tchak tchak deleted the fix-update-champs branch August 8, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants