Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pipedrive): remove pipedrive #9396

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

tchak
Copy link
Member

@tchak tchak commented Aug 8, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Aug 8, 2023

PR Summary

  • Files Removed
    Several files related to 'pipedrive' and 'demandes' were removed. These include controllers, dashboard, helper, jobs, along with a set of files associated with 'pipedrive', including the 'api', 'deal_adapter', 'organization_adapter', and 'person_adapter'. Furthermore, the 'pipedrive_service' was also deleted along with the views of 'demandes', secrets configuration file, and specification for 'demandes_controller'.

  • Key Removal in Config File
    The 'pipedrive' key was safely removed from 'config/secrets.yml' file, which was a part of configuration.

  • Methods Removal
    Specific functionalities associated with 'pipedrive' were removed, these include the 'pipedrive_key' method from the 'BizDev' class and the 'get_deals_ids_for_person' method from the 'Pipedrive::DealAdapter' class.

@tchak tchak force-pushed the remove-piepdrive branch from 6648306 to ca40669 Compare August 10, 2023 08:29
@mfo mfo added this pull request to the merge queue Aug 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2023
@mfo mfo added this pull request to the merge queue Aug 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2023
@mfo mfo added this pull request to the merge queue Aug 14, 2023
Merged via the queue into demarches-simplifiees:main with commit 28de1a7 Aug 14, 2023
@tchak tchak deleted the remove-piepdrive branch November 28, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants