Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctif : exclut les dossiers en brouillon de la recherche (etq instructeur) #9414

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

E-L-T
Copy link
Contributor

@E-L-T E-L-T commented Aug 24, 2023

Lorsqu'un instructeur faisait une recherche par id d'un dossier encore en brouillon (donc sans groupe instructeurs) on avait une erreur 500.

cf https://demarches-simplifiees.sentry.io/issues/4275606696/?project=1429550&query=is%3Aunresolved&referrer=issue-stream&stream_index=2

@E-L-T E-L-T added the bug label Aug 24, 2023
@what-the-diff
Copy link

what-the-diff bot commented Aug 24, 2023

PR Summary

  • Enhanced Search Functionality in 'recherche_controller.rb'
    This PR adds a new condition in the search controller, enhancing the search function to identify and ignore any unprocessed and incomplete files, known as 'drafts'. This means that search results will only display completed files, streamlining the search process for users.

  • User-Specified Access Boundaries
    To further refine the search function and enhance privacy features, another condition was added to the search controller. The update ensures that only cases assigned to a user, or 'instructor', will appear in their search results. If a case falls outside of an instructor's domain, the system will not include it in the provided results, reinforcing security measures.

  • Extended Test Coverage
    This PR introduces a new test scenario under 'recherche_controller_spec.rb' to ensure the newly implemented conditions are effective. This specific test verifies that when unassigned drafts are part of the search, these preliminary files aren't included in the search results. Consequently, this bolsters confidence in the system's ability to only fetch relevant and completed files.

@E-L-T E-L-T marked this pull request as ready for review August 24, 2023 14:40
@E-L-T E-L-T force-pushed the exclude-brouillon-dossiers-from-recherche branch 3 times, most recently from 9a1543f to a4015c5 Compare August 29, 2023 12:17
@LeSim LeSim force-pushed the exclude-brouillon-dossiers-from-recherche branch from a4015c5 to 0bc7d61 Compare August 29, 2023 12:20
@LeSim LeSim enabled auto-merge August 29, 2023 12:24
@LeSim LeSim added this pull request to the merge queue Aug 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2023
@LeSim LeSim added this pull request to the merge queue Aug 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2023
@LeSim LeSim added this pull request to the merge queue Aug 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2023
@LeSim LeSim force-pushed the exclude-brouillon-dossiers-from-recherche branch from 0bc7d61 to 9978908 Compare August 30, 2023 12:12
@LeSim LeSim enabled auto-merge August 30, 2023 12:12
@LeSim LeSim added this pull request to the merge queue Aug 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 30, 2023
@LeSim LeSim added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit a211d4f Aug 31, 2023
@LeSim LeSim deleted the exclude-brouillon-dossiers-from-recherche branch August 31, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants