Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: fix SVA decision date when start date is at end of month and with correction delay #9419

Merged

Conversation

colinux
Copy link
Member

@colinux colinux commented Aug 29, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Aug 29, 2023

PR Summary

  • Adjustment in Decision Date Calculation Method
    The logic behind our decision date calculation has been improved in app/services/sva_svr_decision_date_calculator_service.rb. The way we add the duration and delay corrections together has been modified. This is aimed at more accuracy in our operations.

  • Setup For Procedure Processing Job Tests
    A new setup routine has been added in spec/jobs/procedure_sva_svr_process_dossier_job_spec.rb. Essentially, what this does is pre-set a specific date for when travel time calculation tests are being conducted. This will ensure more consistent and reliable testing results.

  • Enhancements in Decision Date Calculator Tests
    Our testing procedures for the decision date calculation processes have been expanded in spec/services/sva_svr_decision_date_calculator_service_spec.rb. These new tests ensure that the decision date is calculated correctly based on different starting dates and the number of days in various months. This helps us validate our decision date calculation logic with a suite of different scenarios and conditions to ensure our calculations are correct regardless of the circumstances.

@tchak tchak added this pull request to the merge queue Aug 29, 2023
Merged via the queue into demarches-simplifiees:main with commit fe78522 Aug 29, 2023
@colinux colinux deleted the fix-sva-decision-end-of-month branch October 2, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants